Removes references to XRInputSource.gamepad from explainer and index.bs#782
Merged
Conversation
NellWaliczek
commented
Jul 30, 2019
NellWaliczek
marked this pull request as ready for review
July 30, 2019 18:52
toji
approved these changes
Jul 30, 2019
toji
left a comment
toji
left a comment
Member
There was a problem hiding this comment.
One potential change, but otherwise this LGTM!
Member
|
Latest updates still LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs to execute the decision to split the WebXR API into separate modules. This PR handles removing the content moving to the new WebXR Gamepads Module. Removed content can be found in the partner PR in the new module repo immersive-web/webxr-gamepads-module#1