Skip to content

Fix detached array in XRRay.matrix algorithm#716

Merged
toji merged 1 commit into
immersive-web:masterfrom
bialpio:patch-1
Jun 19, 2019
Merged

Fix detached array in XRRay.matrix algorithm#716
toji merged 1 commit into
immersive-web:masterfrom
bialpio:patch-1

Conversation

@bialpio

@bialpio bialpio commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR #684.

Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR immersive-web#684.

@Manishearth Manishearth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@toji

toji commented Jun 19, 2019

Copy link
Copy Markdown
Member

Marked as non substantive for IPR from ash-nazg.

@toji

toji commented Jun 19, 2019

Copy link
Copy Markdown
Member

Thanks! Marked this change as non substantive because it's effectively a typo correction. That way you don't have to go through the IPR process prior to merging.

@toji
toji merged commit a8e2a40 into immersive-web:master Jun 19, 2019
@bialpio

bialpio commented Jun 19, 2019

Copy link
Copy Markdown
Contributor Author

Thanks! I've linked my W3C account to the github account but only after issuing the PR & seeing some red there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants