Rename getPose arg referenceSpace->baseSpace#659
Merged
Merged
Conversation
The use of `referenceSpace` here may inadvertently suggest that it only takes an `XRReferenceSpace` object, when in reality it can take any `XRSpace`. Using `baseSpace` as a replacement at the suggestion of @klausw and @thetuvix. Plus it's fun to say: `getPose` finds the place of your space in the baseSpace's space! ;D
Manishearth
approved these changes
May 20, 2019
Manishearth
left a comment
Manishearth
left a comment
Contributor
There was a problem hiding this comment.
This also should change reference->base in https://github.com/immersive-web/webxr/pull/654/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR1132
Member
Author
|
Thanks for catching that! |
klausw
approved these changes
May 20, 2019
Member
Author
|
@NellWaliczek is the one that initially asked for this change, but is unavailable for reviews for the next few days. In the meantime I'd prefer to get this landed now under the assumption that it's less confusing than the previous verbiage. I'll happily take the blame if Nell takes issue with |
NellWaliczek
left a comment
NellWaliczek
left a comment
Member
There was a problem hiding this comment.
Looks good, though are any changes needed in the explainer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concerns raised after landing #654
The use of
referenceSpacehere may inadvertently suggest that it onlytakes an
XRReferenceSpaceobject, when in reality it can take anyXRSpace. UsingbaseSpaceas a replacement at the suggestion of@klausw and @thetuvix.
Plus it's fun to say:
getPosefinds the place of your space in thebaseSpace's space! 😉