Skip to content

Remove non-object [SameObject]s#618

Merged
toji merged 1 commit into
immersive-web:masterfrom
Manishearth:rm-sameobject
Apr 30, 2019
Merged

Remove non-object [SameObject]s#618
toji merged 1 commit into
immersive-web:masterfrom
Manishearth:rm-sameobject

Conversation

@Manishearth

Copy link
Copy Markdown
Contributor

These are bools and enums which aren't objects, [SameObject] will not work on them.

r? @toji

@toji

toji commented Apr 30, 2019

Copy link
Copy Markdown
Member

Ooh! Good catch. Thanks!

@toji
toji merged commit 0428078 into immersive-web:master Apr 30, 2019
@Manishearth
Manishearth deleted the rm-sameobject branch August 13, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants