Make origin offset immutable#612
Merged
Merged
Conversation
Member
Author
|
This is the same PR as #589, but due to a dumb branch deletion on my part and a dumber restriction on GitHub's part, that PR is now un-re-openable forevermore. So y'all get this one now instead. 😝 FWIW this addresses the feedback given in the previous PR, primarily moving the offset reference space creation mechanism from a constructor to a method, which definitely feels cleaner. PTAL! |
Manishearth
approved these changes
Apr 27, 2019
NellWaliczek
left a comment
NellWaliczek
left a comment
Member
There was a problem hiding this comment.
👍 on the design. A few minor questions
toji
force-pushed
the
immutable_origin_offset
branch
from
April 30, 2019 18:24
540d77f to
10a60a0
Compare
Member
Author
|
Addressed the feedback about the unnecessary new text, and the other two comments appear to be potential non-issues? Please take another look. |
Fixes #580. Changes originOffset to be immutable and establish that the way that the originOffset changes is by constructing a new reference space with the base space and an additional offset to apply on top of it. This should hopefully solve several timing issues related to changing the originOffset mid-frame.
toji
force-pushed
the
immutable_origin_offset
branch
from
May 1, 2019 00:13
10a60a0 to
917d088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #580. Changes originOffset to be immutable and establish that the
way that the originOffset changes is by creating a new reference
space with the
getOffsetReferenceSpace()method of the base space.This should hopefully solve several timing issues related to changing the
originOffset mid-frame.