Fixup frame and viewport caching to be explicit#1093
Merged
Conversation
toji
approved these changes
Jul 1, 2020
| 1. Set |session|'s [=pending render state=] to <code>null</code>. | ||
| 1. Let |oldLayer| be |activeState|'s {{XRRenderState/baseLayer}}. | ||
| 1. Set |activeState| to |newState|. | ||
| 1. If |oldLayer| is not equal to |activeState|'s {{XRRenderState/baseLayer}}, [=update the viewports=] for |session|. |
Member
There was a problem hiding this comment.
This is good, but it doesn't account for the possibility that the existing baseLayer's dimensions change. That's an edge case, admittedly, and I don't think you need to block this PR because of it, just something to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1090
Also fixes #1092 by adding a timestamp comparison.
Preview | Diff