英大文字のお気に入りタグから英小文字のカラムを開くように修正#64
Merged
takayamaki merged 1 commit intoimas:imastodonfrom Sep 5, 2017
Merged
Conversation
Collaborator
|
対応の横並びとはならないのですが、 ここを name: self.name.downcase! |
Collaborator
|
(補足: jsにあまり処理をさせたくないという個人的な思いがあります) |
Member
Author
|
FavouriteTag#to_json_for_apiでdowncaseすると、Reactが取得した時点で既に小文字になってしまうのですよね… 「sidem」ではなく「SideM」でtootしたい、というのは割と強いこだわりがあります。 |
lnanase
approved these changes
Sep 5, 2017
fvh-P
pushed a commit
to fvh-P/mastodon
that referenced
this pull request
Dec 18, 2017
- toLowerCaseが原因で imas#96 が期待する動作をしていないため。 - toLowerCaseを付加した理由のバグが mastodon#4804 にて修正済みのため。
takayamaki
added a commit
that referenced
this pull request
Dec 18, 2017
- toLowerCaseが原因で #96 が期待する動作をしていないため。 - toLowerCaseを付加した理由のバグが mastodon#4804 にて修正済みのため。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReactのLinkタグのリンク先にtoLowerCase()を噛ませることで英小文字のカラムを開くように修正しました
related #62