Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1249.
Planar writing packs the source array bytes directly, so a uint16 array can be written under a DICOM transfer syntax with the opposite byte order and read back with changed pixel values. Resolve the transfer syntax before packing and convert to its byte order.
The synthetic round-trip regression covers both source byte orders and both little/big-endian transfer syntaxes. Before the fix, two mismatched-order cases fail while two matching-order controls pass. After the fix, the pydicom plugin tests pass without remote fixtures (23 passed, 10 skipped with -m "not needs_internet"). Python 3.12.14, NumPy 2.5.4, pydicom 3.0.2, ImageIO 2.38.1. Format and diff checks pass. No full-plugin or full-package suite pass is claimed.