Add EWPING Reader#707
Merged
Merged
Conversation
Owner
|
Run ./scripts/gen script to update generated files (index and documentation) that we keep. |
Owner
|
The doc is generated from source. |
Owner
|
See |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading the EPWING format.
As mentioned in #88, many older Japanese dictionaries are distributed in the EPWING format. Since this was necessary for my use case, I implemented support for it.
The implementation works by first converting EPWING data into the Yomichan format, and then invoking the existing Yomichan reader. The EPWING-to-Yomichan conversion is implemented with reference to the MIT-licensed project yomichan-import.
This software was extremely helpful to me. Many thanks!