improved detectLangsFromName()#700
Closed
mottla wants to merge 1 commit into
Closed
Conversation
added tests test_lang_detect_6 and test_lang_detect_7 that used to fail before, but now pass. Details: Now we assume that the last occurrence of - or to, separates the target from source language. Note: This way we prevent errors that occur for example with "Neo-Persian to English.." However, we still get wrong results when it is something like "en - Neo-Persian" We cannot uniquely identify the users will when resorting to this function anyway. This way however improves results to a great extent
Owner
|
It's interesting, but I'm not sure. I rather give up on auto-detection of a few odd cases, than to "detect wrong languages", so I'd avoid trying to detect multi-word language names. For "Na vosa vaka-Viti-deu.index", it should skip and not detect. (They should use "fij-deu.index") |
ilius
added a commit
that referenced
this pull request
Jan 28, 2026
ilius
added a commit
that referenced
this pull request
Jan 28, 2026
ilius
added a commit
that referenced
this pull request
Jan 28, 2026
ilius
added a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improved detectLangsFromName
and added tests
test_lang_detect_6
test_lang_detect_7
with tests that used to fail before, but now with the new detectLangsFromName pass.
Details:
Now we assume that the last occurrence of - or to, separates the target from source language. Note: This way we prevent errors that occur for example with "Neo-Persian to English.." However, we still get wrong results when it is something like "en - Neo-Persian" We cannot uniquely identify the users will when resorting to this function anyway. This way however improves results to a great extent