Edict2: Make summary alternatives optional#682
Merged
Conversation
Previously, each entry had a list of summarized definitions included in its l_terms. Make this behavior optional.
benfl
force-pushed
the
optional-summary
branch
from
eb4f425 to
b9f5702
Compare
Owner
|
This removes English alternates? |
Owner
|
Oh |
Contributor
Author
|
I added some additional description, please let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #681, the current behavior is to include summaries of each definition as additional l_terms. This change makes that behavior optional, defaulting to false.