Skip to content

Add Yomichan dictionaries reader#655

Merged
ilius merged 5 commits into
ilius:masterfrom
Electro98:yomichan-reader
May 22, 2025
Merged

Add Yomichan dictionaries reader#655
ilius merged 5 commits into
ilius:masterfrom
Electro98:yomichan-reader

Conversation

@Electro98

Copy link
Copy Markdown
Contributor

Description

I know that's maybe not a very requested feature but because I had a problem with converting my own collection of yomichan formatted dictionaries I wrote an plugin extension.

Questions

  • Is there any possible way to properly implement progress bar if dictionary length is unknown until we read it fully?
  • Are there any metadata (like plugins-meta/index.json) that also need to be updated?
  • I guess code style is differs from original code, isn't it? Any moments that I need to fix?

Limitations

Supports only dictionaries of 3 version and don't implement any interactions with tags or kanji banks.

I haven't found a contribution guideline so if I have missed anything, please let me know.

Closes #622.

@ilius

ilius commented May 21, 2025

Copy link
Copy Markdown
Owner

Please run ./scripts/gen.sh
And ruff format; ruff check --fix --preview
https://github.com/ilius/pyglossary/actions/runs/15165860829/job/42649933687?pr=655

@ilius ilius merged commit e498b19 into ilius:master May 22, 2025
@ilius

ilius commented May 22, 2025

Copy link
Copy Markdown
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading from Yomichan dictionaries

2 participants