[ZEPPELIN-23] Set version of default spark interpreter build profile from 1.1 to 1.3#1
Merged
ilganeli merged 6 commits intoilganeli:ZEPPELIN-23from Jun 3, 2015
Merged
Conversation
Owner
There was a problem hiding this comment.
Nit: To be consistent, we probably want to indent the lines below.
Owner
There was a problem hiding this comment.
Same comment as below, potentially safer to explicitly check the numerical value of the version, e.g.:
String[] split = version.split(".")
int version = Integer.parseInt(split[0]) + Integer.parseInt(split[1])
return version <= 11;
Author
|
@ilganeli Thanks for the feedback! I have updated source code's indentation, also followed your suggestion that check version number in numerical value. |
Author
|
Changed to |
Owner
|
LGTM |
ilganeli
pushed a commit
that referenced
this pull request
Jun 3, 2015
[ZEPPELIN-23] Set version of default spark interpreter build profile from 1.1 to 1.3
Author
|
Thanks! |
ilganeli
pushed a commit
that referenced
this pull request
Jul 8, 2015
…from 1.1 to 1.3 I updated the version of spark used by default throughout the dependency listing to be 1.3.0 (to match the version used in the 1.3 profile). Author: Lee moon soo <[email protected]> Author: Ilya Ganelin <[email protected]> This patch had conflicts when merged, resolved by Committer: Lee moon soo <[email protected]> Closes apache#71 from ilganeli/ZEPPELIN-23 and squashes the following commits: d1d642e [Ilya Ganelin] Merge pull request #1 from Leemoonsoo/ZEPPELIN-23 0108781 [Lee moon soo] update isDataFrameSupported() ac4e8bc [Lee moon soo] check spark version as a numerical number in tests 405da99 [Lee moon soo] Fix indentation 28dd7bf [Lee moon soo] Make unittest pass with spark-1.3 profile cf2ed0c [Lee moon soo] Activate spark-1.3 profile by default. Set spark 1.3.1 as a default version of spark-1.3 profile 13bf6c1 [Lee moon soo] remove z.load() error for spark 1.2, spark 1.3 1402df2 [Ilya Ganelin] Updated default spark version to 1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have activated spark-1.3 profile by default instead of change default spark version from 1.1.1 to 1.3.1. Because of, to make spark 1.3.1 work, not only spark.version but also all related library version should be taken care.
Also unitest are updated to make work with spark 1.3.x