Repository navigation
feat(generate): propose fs read for image directories outside the baseline (--image) - #32
Merged
Merged
Conversation
…eline Signed-off-by: Ilan Harel <[email protected]>
ilanh
force-pushed
the
feat/image-fs-hint
branch
from
November 3, 2026 08:42
7a8d6ed to
5e187ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
generate --image IMAGEinspects the container image (docker, then podman) and prints a stderr proposal of# @openshell fs read <dir>lines for application directories (WORKDIR, ENTRYPOINT/CMD paths,/opt/*,/srv/*, unusual top-level dirs) that fall outside OpenShell 0.1.6's baseline read set and outside the declaredfsroots. It only proposes: the policy on stdout is unchanged. No proposal when the code declares nofsdirective (nofilesystem_policy, nothing restricted) and the WORKDIR is skipped whileinclude_workdiris on.src/image.rs(inspect parsing,docker create+export | tar -tlisting, proposal logic),--image/--image-inspect FILEflagsdocs/CLI.mdregeneratedimage.rs,tests/image_fs.rs(offline via--image-inspect)Verified against the real
context7-openshell:localimage with thefs read /opt/context7directive removed: proposes/opt/context7(and/opt/yarn-v1.22.22); with the directive present it is silent.Independent of the other open PRs (new files; small additions in
main.rs/lib.rsmay need a trivial rebase).