Repository navigation
fix(scan): exclude patterns work with ./ paths, dead and regex patterns are reported - #25
Merged
Merged
Conversation
…thing, document literal excludes Signed-off-by: Ilan Harel <[email protected]>
ilanh
force-pushed
the
fix/exclude-semantics
branch
from
November 3, 2026 08:14
e8639c1 to
eeb4cb1
Compare
ilanh
added a commit
that referenced
this pull request
Nov 3, 2026
…entials (#30) ## What and why Three of five tested projects needed a hand-written custom provider profile, and `providers.sh` only said `# UNMAPPED ... write a custom profile`. - **`generate --scaffold-profiles DIR`** writes `DIR/<id>.yaml` for every unmapped credential (id = env var lower-cased with hyphens): the credential, plus endpoints, `access` and binaries taken from the `egress` directives in the file that declares the credential. `tls=skip` endpoints get `allow_uninspected_credentials: true` (OpenShell's profile lint requires it for L4-only credentialed endpoints); credentials with no egress in their file get `endpoints: []` and TODO comments. Existing files are kept, nothing is written without the flag, no secret values are involved. The `UNMAPPED` comment in `providers.sh` now points to the flag. - **Misleading duplicate warning:** `egress X duplicates an endpoint the profile adds` is now only shown when the profile's `binaries` overlap the rule's binaries (profile bound to `gh`/`git`, app is `node`: the explicit rule is needed, no warning). Profiles that list no binaries keep the old behaviour. - README section "Credentials with no provider profile"; CLI.md regenerated. Checked with the real tool: skeletons generated from anthropic-proxy-rs's sidecar (`tls=skip` case) and synthetic cases all pass `openshell provider profile lint -f` (OpenShell 0.1.6 on the dev server). CI cannot run that, so the tests reload the skeletons with our own profile loader. Tests: `tests/scaffold_profiles.rs` (3 tests) and a unit test. `TOOLCHAIN=1.94 scripts/ci-local.sh` and stable clippy pass. Ordering: independent (new module `scaffold.rs`; small edits in `providers.rs`, `generate.rs`, `main.rs`'s `Generate` arm). Another PR (#26) edits other parts of `main.rs`, and #21/#25 edit `do_scan`; any of them may need a trivial rebase. Closes #13 --------- Signed-off-by: Ilan Harel <[email protected]> Co-authored-by: Ilan Harel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Reworks how
excludebehaves so it stops failing silently.scan ./lint .the walker yields./packages/cli/a.ts, and the relative path kept the leading., so^packages/cli/never matched. Relative paths are now normalised (this also removes the./prefix from source paths in the generated policy comments, a separate small bug seen on Paperclip).[scan].excludeor[lint].excludepattern that matches no file printswarning: [scan].exclude pattern ... matches no file, with a hint. Regex-looking patterns (^packages/(admin|cli)/) get "exclude patterns are not regexes: ... list one entry per directory". Partial scans stay quiet; stdout and--jsonare unchanged.[scan].excludeare never read, solintalready inherits them (checked, including with a.path).[lint].excludestays as lint-only extras. This is now stated in the config docs and the README, with the literal (not regex) matching rule and a per-directory example.Tests:
tests/excludes.rs(shared exclude with and without a.path, no./prefix, regex pattern warning, dead lint pattern, partial scan quiet).TOOLCHAIN=1.94 scripts/ci-local.shand stable clippy pass.Ordering: touches
do_scaninmain.rsandscan.rslike #21 (comment leaders); whichever merges second needs a trivial rebase.Closes #9