Repository navigation
fix(lint): suggest one egress directive per host; fix invalid skill example - #22
Merged
Merged
Conversation
…xample Signed-off-by: Ilan Harel <[email protected]>
ilanh
force-pushed
the
fix/multi-host-egress
branch
from
November 3, 2026 08:03
913493e to
6e6b4ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
generaterejects a comma-separated multi-hostegressline, but the AI skill example and thelintsuggestions used one.lintnow suggests one@openshell egressdirective per host, both in the multi-line help block (each on its own copy-pasteable line, headed "one directive per host") and in the compact one-line form (separated by;).skills/annotate-openshell-policy/SKILL.md: the pip example is now two valid directives, and rule 2 states that there is no multi-host form.tests/egress_suggestions.rs: the suggested lines are one per host and parse, and every fenced ts/python/go/sh block in SKILL.md must scan without errors, so the skill cannot drift from the grammar again.I did not add comma-separated host support to the grammar; one directive per host keeps each rule's reason and binary explicit.
Independent of the other PRs. Tests live in a new file, so there are no merge conflicts with PRs that edit
tests/cli.rs.TOOLCHAIN=1.94 scripts/ci-local.shand stable clippy pass.Closes #8