feat(lint): readable multi-line output with context and category icons - #2

📄 bad-policy.yaml  (3 findings)

✖ 📜 error[policy]: `relative/path` must be an absolute path (OpenShell rejects relative filesystem paths; write the in-sandbox path)
 --> bad-policy.yaml
  = note: at `filesystem_policy.read_write`

✖ 📜 error[policy]: `localhost` is loopback, link-local or unspecified; OpenShell never authorizes these destinations (a sandbox-local service needs no network rule)
 --> bad-policy.yaml
  = note: at `network_policies.api.endpoints[0]`

⚠ 📜 warning[policy]: empty `binaries` matches no executable, so the rule allows nothing
 --> bad-policy.yaml
  = note: at `network_policies.api`

📄 scripts/deploy.sh  (3 findings)

✖ 📝 error[directive]: malformed @openshell directive
 --> scripts/deploy.sh:2:3
  |
1 | #!/usr/bin/env bash
2 | # @openshell egress
  |   ^^^^^^^^^^^^^^^^^ does not match the directive syntax
3 | curl -fsSL https://registry.npmjs.org/left-pad > /opt/out.json
  |
  = help: expected syntax: egress <host>:<port>[,<port>...] reason="..." [access=read-only|read-write|full] [protocol=rest|...] [allow="METHOD:/path"]... [bin=/path] [rule=name] [enforce=enforce|audit] [tls=skip]

⚠ 🌐 warning[net]: unannotated network call to registry.npmjs.org:443
 --> scripts/deploy.sh:3:1
  |
1 | #!/usr/bin/env bash
2 | # @openshell egress
3 | curl -fsSL https://registry.npmjs.org/left-pad > /opt/out.json
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ curl/wget reaches registry.npmjs.org:443 with no matching @openshell egress
  |
  = help: declare the destination on the line above:
          # @openshell egress registry.npmjs.org:443 reason="..."
  = note: a directive covers calls on its own line and up to 8 lines below it (`scope=file` covers the whole file)

⚠ 📁 warning[fs]: filesystem write to /opt/out.json is outside the sandbox
 --> scripts/deploy.sh:3:48
  |
1 | #!/usr/bin/env bash
2 | # @openshell egress
3 | curl -fsSL https://registry.npmjs.org/left-pad > /opt/out.json
  |                                                ^^^^^^^^^^^^^^^ output redirection
  |
  = help: allow writes to the directory:
          # @openshell fs write /opt reason="..."
          or, if this is not a real write:
          # @openshell ignore kind=fs reason="..."
  = note: the sandbox may write only under /tmp and the declared `fs write` roots

📄 src/server.ts  (5 findings)

⚠ 🔑 warning[env]: secret-like variable GITHUB_TOKEN is read but no provider declares it
 --> src/server.ts:5:17
  |
3 |
4 | export async function sync(userId: string) {
5 |   const token = process.env.GITHUB_TOKEN;
  |                 ^^^^^^^^^^^^^^^^^^^^^^^^ reads GITHUB_TOKEN
6 |   const res = await fetch("https://api.github.com/repos/ilanh/openshell-annotate/issues", {
  |
  = help: if an OpenShell provider supplies it, declare it:
          // @openshell provider GITHUB_TOKEN
          if it is not a credential:
          // @openshell ignore kind=env reason="..."

⚠ 🌐 warning[net]: unannotated network call to api.github.com:443
 --> src/server.ts:6:21
  |
4 | export async function sync(userId: string) {
5 |   const token = process.env.GITHUB_TOKEN;
6 |   const res = await fetch("https://api.github.com/repos/ilanh/openshell-annotate/issues", {
  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ fetch() reaches api.github.com:443 with no matching @openshell egress
7 |     headers: { Authorization: `Bearer ${token}` },
  |
  = help: declare the destination on the line above:
          // @openshell egress api.github.com:443 reason="..."
  = note: a directive covers calls on its own line and up to 8 lines below it (`scope=file` covers the whole file)

⚠ 📁 warning[fs]: filesystem write to /var/lib/app/state.json is outside the sandbox
  --> src/server.ts:9:3
   |
 7 |     headers: { Authorization: `Bearer ${token}` },
 8 |   });
 9 |   writeFileSync("/var/lib/app/state.json", JSON.stringify(await res.json()));
   |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ filesystem write (writeFileSync)
10 |   spawn("git", ["fetch", "origin"]);
   |
   = help: allow writes to the directory:
           // @openshell fs write /var/lib/app reason="..."
           or, if this is not a real write:
           // @openshell ignore kind=fs reason="..."
   = note: the sandbox may write only under /tmp and the declared `fs write` roots

ℹ ⚙️ info[exec]: subprocess runs a program the policy does not describe
  --> src/server.ts:10:3
   |
 8 |   });
 9 |   writeFileSync("/var/lib/app/state.json", JSON.stringify(await res.json()));
10 |   spawn("git", ["fetch", "origin"]);
   |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ subprocess
11 |   return userId;
   |
   = help: if the program opens its own connections, add `bin=<path>` to its egress directive; otherwise:
           // @openshell ignore kind=exec reason="..."
   = note: OpenShell matches network rules on the spawned binary, not on this script

✖ 📝 error[directive]: egress requires reason="..." (it becomes the comment in policy.yaml)
  --> src/server.ts:14:4
   |
12 | }
13 |
14 | // @openshell egress api.stripe.com:443
   |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
15 | export async function charge() {
   |

📄 src/worker.py  (2 findings)

⚠ 🌐 warning[net]: network call with no literal destination
 --> src/worker.py:5:12
  |
3 | def pull(url):
4 |     # destination is only known at runtime
5 |     return requests.get(url, timeout=5)
  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ requests: destination is not a string literal
6 |
  |
  = help: declare the host this call connects to, on the line above:
          # @openshell egress <host>:443 reason="..."
          or, if it is not real egress:
          # @openshell ignore kind=net reason="..."
  = note: a directive covers calls on its own line and up to 8 lines below it (`scope=file` covers the whole file)

⚠ 📁 warning[fs]: filesystem write to /srv/cache/blob.bin is outside the sandbox
 --> src/worker.py:8:10
  |
6 |
7 | def save(blob):
8 |     with open("/srv/cache/blob.bin", "wb") as f:
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ open() for writing
9 |         f.write(blob)
  |
  = help: allow writes to the directory:
          # @openshell fs write /srv/cache reason="..."
          or, if this is not a real write:
          # @openshell ignore kind=fs reason="..."
  = note: the sandbox may write only under /tmp and the declared `fs write` roots

✖ 4 errors · ⚠ 8 warnings · ℹ 1 info  (13 findings in 4 files; 1 directive)
by category: 📝 directive 2 · 🔑 env 1 · ⚙️ exec 1 · 📁 fs 3 · 🌐 net 3 · 📜 policy 3