Skip to content

diff-logs does not find the repo root and treats probe scripts in the repo as source #11

Closed

Description

@ilanh

Summary

Two problems with diff-logs:

  • (a) Run from a subdirectory it does not walk up to the repo root (openshell-annotate.toml).
  • (b) A probe driver that lives inside the repo is scanned as source and --write inserts directives into it.

Steps to reproduce

(a) cd openshell && openshell-annotate diff-logs sandbox-logs.txt: only that directory is scanned, so it reports 0 stale directives and a wrong place: for suggestions.

(b) Keep the probe driver in the repo (openshell/exercise.sh, openshell/observed-egress.sh) and run diff-logs --write: a directive is inserted into those scripts.

Expected

  • Walk up to the directory containing openshell-annotate.toml, like the other commands.
  • Honour [scan].exclude, and add an [diff-logs] exclude, so probe scripts are not used as directive targets.

Actual

Wrong root, wrong placement, and directives written into probe scripts.


Found while testing five real projects (see the local candidate report). Numbered #5 in that report.

Activity

  1. added
    bugSomething is not working
    diff-logsopenshell-annotate diff-logs
    on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is not workingdiff-logsopenshell-annotate diff-logs

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions