You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 471b026
Browse filesBrowse the repository at this point in the historyBrowse files
fix(providers): relocatable profile paths in providers.sh; note prover limit for tls=skip (#29)
## What and why
Two small items from the candidate testing:
- **`providers.sh` hard-coded a relative path**
(`$ROOT/../../OpenShell/providers/...`) for profiles outside the repo,
which breaks when the repo or the OpenShell checkout moves. Profile
files outside the repo (a `..` path, or an absolute `profiles_dir`) are
now referenced as `"${OPENSHELL_PROFILES_DIR:-<dir>}/<file>"` and the
script gets a comment explaining the override. Profiles inside the repo
still use `"$ROOT/<path>"`; no absolute machine paths are written for
repo-relative profiles.
- **Prover and `tls=skip`:** `openshell-prover check` returned
`unsupported` for `tls: skip` with OpenShell 0.1.6. That is upstream
behaviour (nothing is filed upstream; it is on the local tracking issue
#19), so the `tls` attribute help now says so (DIRECTIVES.md
regenerated).
Tests: `tests/providers_script_paths.rs` (relative outside, absolute,
inside). `TOOLCHAIN=1.94 scripts/ci-local.sh` and stable clippy pass.
Ordering: independent. (README line next to the `profiles_dir` config
comment only.)
Closes#18
---------
Signed-off-by: Ilan Harel <[email protected]>
Co-authored-by: Ilan Harel <[email protected]>
Copy file name to clipboardExpand all lines: docs/DIRECTIVES.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -64,7 +64,7 @@ Attributes:
64
64
|`deny`|`METHOD:/path`| yes | Request subtracted from what is allowed. Repeatable; needs `allow` or `access`. |
65
65
|`bin`|`/absolute/real/path`| no | Binary that opens the connection. Overrides the nearest `@openshell bin` and `[languages]` in the config. |
66
66
|`rule`|`[A-Za-z0-9_-]+`| no | Name of the `network_policies` entry (default: slug of the host). Must not start with `_provider_`. |
67
-
|`tls`|`skip`| no | Relay without TLS termination. Cannot be combined with request inspection. |
67
+
|`tls`|`skip`| no | Relay without TLS termination. Cannot be combined with request inspection. Use it for clients that do not trust the OpenShell CA. `openshell-prover check` reported such policies as `unsupported` with OpenShell 0.1.6 (tracked in #19). |
"ROOT=\"$(git rev-parse --show-toplevel 2>/dev/null || pwd)\"\n# Provider profiles outside this repo are read from $OPENSHELL_PROFILES_DIR when it is set (e.g. <OpenShell checkout>/providers).\n",
AttrSpec{name:"deny",multi:true,values:"METHOD:/path",help:"Request subtracted from what is allowed. Repeatable; needs `allow` or `access`."},
70
70
AttrSpec{name:"bin",multi:false,values:"/absolute/real/path",help:"Binary that opens the connection. Overrides the nearest `@openshell bin` and `[languages]` in the config."},
71
71
AttrSpec{name:"rule",multi:false,values:"[A-Za-z0-9_-]+",help:"Name of the `network_policies` entry (default: slug of the host). Must not start with `_provider_`."},
72
-
AttrSpec{name:"tls",multi:false,values:"skip",help:"Relay without TLS termination. Cannot be combined with request inspection."},
72
+
AttrSpec{name:"tls",multi:false,values:"skip",help:"Relay without TLS termination. Cannot be combined with request inspection. Use it for clients that do not trust the OpenShell CA. `openshell-prover check` reported such policies as `unsupported` with OpenShell 0.1.6 (tracked in #19)."},
0 commit comments