Closed
Conversation
Author
|
I think the list holder could be merged to some shared struct, to not copy similar features. |
ikatson
requested changes
Oct 14, 2025
Owner
ikatson
left a comment
ikatson
left a comment
There was a problem hiding this comment.
Left a couple comments, but the main one is critical - don't copy-paste code please, but refactor instead.
It's fine to "break" it, as it'll all be part of 9 release which is breaking anyway
| @@ -0,0 +1,278 @@ | |||
| use anyhow::{Context, Result}; | |||
Owner
There was a problem hiding this comment.
please don't copy-paste, use the same file. Feel free to rename Blocklist and blocklist.rs to "IpRanges" and "ip_ranges.rs".
Of course "is_blocked" method should be renamed to just "contains", and similar methods if they exist should be renamed too, to make the struct reusable.
| .blocked_outgoing | ||
| .fetch_add(1, Ordering::Relaxed); | ||
| debug!(?addr, "blocked outgoing connection"); | ||
| debug!(?addr, "blocked outgoing connection (by the blacklist)"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#496
Please review, before merge as untested (only passing
cargo test)P.S. Why not to use the similar
Optionfor the blacklist also, instead of empty struct. Is this updating dynamically somewhere? I think we may have ability to update list without app reload.