Include crate version in client fingerprint portion of peer_id#374
Merged
ikatson merged 2 commits intoikatson:mainfrom Jun 2, 2025
Merged
Include crate version in client fingerprint portion of peer_id#374ikatson merged 2 commits intoikatson:mainfrom
peer_id#374ikatson merged 2 commits intoikatson:mainfrom
Conversation
Owner
|
This is great, thanks! I wanted to do this for a long time but never got to it. One minor thing: can you please change getrandom create to random, cause we use rand already everywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
librqbit's version number in its peer ids by default. Allow applications to specify a custom client fingerprint, and introduce a function to generate Azereus-style fingerprints from a two byte string and version tuple. Also bump librqbit-core to 5.0, since this PR changes its public API.