Merged
Conversation
The previous implementation would falsely detect a path traversal in a filename such as "foo... bar". This patch changes the check function so that it inspects `PathBuf` components instead of substrings.
illfygli
force-pushed
the
fix-path-traversal
branch
from
d2bb000 to
f020673
Compare
Owner
|
Thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would falsely detect a path traversal in a filename such as "foo... bar".
This patch changes the check function so that it inspects
PathBufcomponents instead of substrings.I don't know much Rust so I hope this makes sense. I have test-driven it myself and verified that I can now add a torrent with a filename containing
...which previously did not work.