Initial support for interface binding#309
Closed
Quackdoc wants to merge 1 commit intoikatson:mainfrom
Closed
Conversation
Owner
|
"Don't clone as much" - I wouldn't worry about it before it all works "Figure out how to pass interface to tracker" - by a quick look there's nothing to "refactor", just extend. The only reasons to refactor would be growing code complexity but that can be addressed on top. There's 2 things: the "reqwest::Client" passed for HTTP trackers - that needs to be extended with "interface". The second is for UDP trackers need to pass down interface. I would also resolve interface to index was early as possible and use that instead of name everywhere (if that works) |
Owner
|
Fixed in #445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a draft, this is "working" sort of when you pass the interface to the tracker, without passing the interface and binding to it, it announces the wrong thing. As such setting initial-peer will work, but no trackers will see the client.
I haven't really proof read any of the changes yet, this is just so I can get help with the main issue.
Additionally this PR makes changes to how tcp port binding works. if a user wishes to select a single port (IE. port forwarding) we can easily do this by passing the port..port + 1 due to how ranges work. the changes are purely convenience. Min port being greater then max port will give a range with nothing in it, so doing this will at least pass a single port, but perhaps throwing a warning or even an error would be better.
the second one I am really struggling with as it seems like it may require quite a bit of things to change.
addresses #304