CI: Use binstall, Dynamic dockerhub user and push#282
Conversation
If I read this correctly, it will create junk in my dockerhub (ikatson/rqbit) on every PR etc. Don't like this if so. At least need to guard it somehow.
|
Binstall is great, i only heard about it recently during my dive into tauri 2. It will also fall back to doing a normal install if the binaries arent already hosted so it should be a transparent change for the most part.
Yeah this would create a separate tag for PR, the thought behind it is that it would make it easier to test for PR for you and the end users. We can remove the docker pushes if you want that way atleast the test and docker build is ran on PR to make sure the PR isnt breaking anything. |
|
There's a few changes here and I feel different about all of them. Let's break up into details. Feel free to merge the LGTM ones separately in a different PR, but there's one change here that I can't agree with yet. Binstall changeLGTM, no concerns Run tests on every push to every branchMixed feelings about this one, but I get the intention and I'm ready to try this out, so LGTM. Dockerhub - replace "ikatson" with DOCKERHUB_USERNAMELGTM, no concerns. Run linux release on every push to every branch / tag and on every pull request.Can't approve this. The intention was to build final artifacts (including docker) is just for release, not for pull requests and pushes to random branches.
I don't need docker to test it. I can build myself locally if needed. And I don't want a tag for unmerged PRs in the official dockerhub. I also don't need them for random branches that I create and push to all the time.
I guess you mean developers, not end users right?
As mentioned above, the intention about docker builds wasn't to make sure it's not breaking anything but to create artifacts for final release. For other purposes test.yaml should be enough. If you really need to test docker builds, e.g. you are changing the actual docker build process, that's a different story, but it was so rare so far that wasn't an issue. |
|
That all sounds good to me, ill go ahead and revert the change for the change for the non main linux release and see if i can combine the two docker build sections and let you know. Thanks for taking a look at it. |
Signed-off-by: Luis Garcia <[email protected]>
Signed-off-by: Luis Garcia <[email protected]>
19117cc to
6c91f1e
Compare
Signed-off-by: Luis Garcia <[email protected]>
|
Ok i think this is all set. Sorry for the long turnaround time |
|
Thanks for finishing this! |
Uh oh!
There was an error while loading. Please reload this page.