Skip to content

CI: Use binstall, Dynamic dockerhub user and push#282

Merged
ikatson merged 3 commits intoikatson:mainfrom
luigi311:binstall
Mar 8, 2025
Merged

CI: Use binstall, Dynamic dockerhub user and push#282
ikatson merged 3 commits intoikatson:mainfrom
luigi311:binstall

Conversation

@luigi311
Copy link
Copy Markdown
Contributor

@luigi311 luigi311 commented Nov 24, 2024

  • Uses binstall to avoid building tauri-cli
  • Sets tests and linux release to always run on push/pr
    • Useful to always catch regressions and testing new branches via docker
  • Adjust the linux release workflow so it does not fail when a dockerhub username is not provided
    • Useful for other contributors to not get failed actions if they dont use dockerhub

@ikatson
Copy link
Copy Markdown
Owner

ikatson commented Nov 27, 2024

Uses binstall to avoid building tauri-cli
Wow, this looks like it might speed things up quite a bit. Love this, didn't know about binstall.

Sets tests and linux release to always run on push/pr

If I read this correctly, it will create junk in my dockerhub (ikatson/rqbit) on every PR etc. Don't like this if so. At least need to guard it somehow.

Adjust the linux release workflow so it does not fail when a dockerhub username is not provided. Useful for other contributors to not get failed actions if they dont use dockerhub
Seems alright if it doesn't impact the main repo

@luigi311
Copy link
Copy Markdown
Contributor Author

Wow, this looks like it might speed things up quite a bit. Love this, didn't know about binstall.

Binstall is great, i only heard about it recently during my dive into tauri 2. It will also fall back to doing a normal install if the binaries arent already hosted so it should be a transparent change for the most part.

If I read this correctly, it will create junk in my dockerhub (ikatson/rqbit) on every PR etc. Don't like this if so. At least need to guard it somehow.

Yeah this would create a separate tag for PR, the thought behind it is that it would make it easier to test for PR for you and the end users. We can remove the docker pushes if you want that way atleast the test and docker build is ran on PR to make sure the PR isnt breaking anything.

@luigi311 luigi311 marked this pull request as draft November 27, 2024 23:00
@ikatson
Copy link
Copy Markdown
Owner

ikatson commented Nov 28, 2024

There's a few changes here and I feel different about all of them. Let's break up into details. Feel free to merge the LGTM ones separately in a different PR, but there's one change here that I can't agree with yet.

Binstall change

LGTM, no concerns

Run tests on every push to every branch

Mixed feelings about this one, but I get the intention and I'm ready to try this out, so LGTM.

Dockerhub - replace "ikatson" with DOCKERHUB_USERNAME

LGTM, no concerns.

Run linux release on every push to every branch / tag and on every pull request.

Can't approve this. The intention was to build final artifacts (including docker) is just for release, not for pull requests and pushes to random branches.

Yeah this would create a separate tag for PR, the thought behind it is that it would make it easier to test for PR for you

I don't need docker to test it. I can build myself locally if needed. And I don't want a tag for unmerged PRs in the official dockerhub. I also don't need them for random branches that I create and push to all the time.

and the end users.

I guess you mean developers, not end users right?
Developers can build themselves on whatever system they are developing. Local "cargo build" should be enough, shouldn't it? If you need to test on docker for some reason, building docker locally should do the job

docker build is ran on PR to make sure the PR isnt breaking anything.

As mentioned above, the intention about docker builds wasn't to make sure it's not breaking anything but to create artifacts for final release. For other purposes test.yaml should be enough.

If you really need to test docker builds, e.g. you are changing the actual docker build process, that's a different story, but it was so rare so far that wasn't an issue.

@luigi311
Copy link
Copy Markdown
Contributor Author

That all sounds good to me, ill go ahead and revert the change for the change for the non main linux release and see if i can combine the two docker build sections and let you know. Thanks for taking a look at it.

@luigi311 luigi311 force-pushed the binstall branch 4 times, most recently from 19117cc to 6c91f1e Compare March 8, 2025 00:45
@luigi311 luigi311 marked this pull request as ready for review March 8, 2025 01:17
@luigi311
Copy link
Copy Markdown
Contributor Author

luigi311 commented Mar 8, 2025

Ok i think this is all set. Sorry for the long turnaround time

@luigi311 luigi311 requested a review from ikatson March 8, 2025 01:39
@ikatson ikatson merged commit e4595a7 into ikatson:main Mar 8, 2025
5 checks passed
@ikatson
Copy link
Copy Markdown
Owner

ikatson commented Mar 8, 2025

Thanks for finishing this!

@luigi311 luigi311 deleted the binstall branch March 8, 2025 18:58
@luigi311 luigi311 changed the title CI: Use binstall, Always run tests/linux CI: Use binstall, Dynamic dockerhub user and push Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants