Merged
Conversation
ikatson
approved these changes
Oct 12, 2024
ikatson
reviewed
Oct 12, 2024
crates/librqbit/src/session.rs
Outdated
| pub async fn pause(&self, handle: &ManagedTorrentHandle) -> anyhow::Result<()> { | ||
| handle.locked.write().paused = true; | ||
| handle.pause()?; | ||
| let prev_state; |
Owner
There was a problem hiding this comment.
Can it be simplified by first calling handle.pause(), and then only if it was successful set paused = true?
This way the lock is taken only once
Contributor
Author
There was a problem hiding this comment.
Yeah, it makes sense. Updated.
ikatson
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the great library!
I've recently faced a bug when pausing while initializing torrent returned an error, but it changed the internal flag. This fix should prevent such behavior.