refactor: use byteorder crate to enhance portability (to BE systems), and enhance code readability, avoiding manual byte manipulations#250
Merged
ikatson merged 1 commit intoikatson:mainfrom Oct 3, 2024
Conversation
… and enhance code readability, avoiding manual byte manipulations
Owner
|
nit: if I wrote this today, I'd just use std's to_be_bytes / from_be_bytes to avoid adding a dependency. I guess I didn't know about these functions when I wrote this originally years ago. But the change looks ok anyway, the above is just FYI, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this also fixes what I think is a small bug here: https://github.com/ikatson/rqbit/pull/250/files#diff-b4f79704f8a70bb6832cd8eb994612ba62b1e199efcebd39228d0761a257920dR285
where
6is always printed instead of the invalid size like other instances do