Merged
Conversation
Owner
|
Thanks @PastaPastaPasta for the PR! Agree it makes sense even without UI support, so can merge this first. Added a few minor comments, should be very quick to address. |
ikatson
requested changes
Oct 2, 2024
ikatson
reviewed
Oct 2, 2024
c555e07 to
57db99e
Compare
Owner
|
@PastaPastaPasta if you want to fix the UI, I think an easy fix would be to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for BEP-53 Select Only magnet extension
This does not include full support in the GUI / web interface. When initially adding a torrent with SO, the gui will show ALL as selected, even though the actual download will only download the sections needed for that file. Once a torrent has been added, the file list then becomes accurate.
See below patch, for how I tried to have the UI be reactive to
so=however, this patch didn't work. I'd love to get feedback on a patch that works, but even without I think this PR is valuable and net positive