Remove error when adding duplicate torrents#230
Merged
ikatson merged 1 commit intoikatson:mainfrom Sep 1, 2024
Merged
Conversation
Owner
|
I don't have a strong opinion on this, so if this caused trouble, no problem merging. However there's a chance the torrent was added when different parameters, e.g. output_folder. So maybe at least return a different status code to indicate the difference between created and already exists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error is kinda unnecessary here. Makes the user have to make another API request beforehand to check if the torrent is already managed. This can easily be simplified by just returning the managed torrent instead of an error.