Conversation
|
As you can see, these files are needed for the build. I agree they are annoying though. A better solution might be to run "npm build" as part of "build.rs". |
|
Thanks for explanation -I realized that rust build was problem, when I saw all jobs failed. No big issue - just requires bit more attention to what is included in commits. |
|
Yes that's expected. These files don't get generated during rust build, that's why they are committed. But as I mentioned above, I think we need to get rid of them if favor of building npm in build.rs, cause these files are causing a bit of pain |
|
Addressed in #180 |
These files are ignored by git, but were pushed into repo in past.
They just mess with newly generated UI files.
Used :
to get rid of them - I guess it could be useful also for main branch.