Conversation
|
On b38c371 test failure was caused by platform variations? Same code, except comment in next commit. |
|
The tests flake out sometimes, must be a bug somewhere. Your code style was good btw, I only split it up to reuse parts of your function. Btw I tried pasting the playlist URL into VLC and it doesn't seem to work: it seems VLC expects playlist to be a local file, and when pasting into "open network" (or whatever it's called) nothing happens. Only if I download the playlist, then open it works. Is it the same for you or I'm doing something wrong? |
|
@ikatson Opening playlist URL in VLC works for me on linux, if MIME is text/plain - I think VLC has problem with apple MIME type - application/vnd.apple.mpegurl - that's why I left it there only for Apple platforms. This MIME is officially for Apple HLS - and this is not our use case. But I thought, as you added this MIME, it might have some advantage on Apple? Or with this MIME, it might require extended M3U syntax - e.g. start with #M3UEXT line etc. Will try |
Thanks, that explains why nothing actually worked for me on Mac! I added MIME type there not because it wasn't working without it, but just because the wikipedia page for M3U was listing this mime type on the first line. It actually says later that that apple one is for HLS (and I didn't read that at first), and a better one to use for general M3U is e.g. "application/mpegurl". Fixing this here: #176 |
Thanks for #172 - definitely better code organization, just couple of edits from my linux perspective: