Skip to content

fix ribbon cause scroll not working#1640

Merged
ivan-nginx merged 1 commit intoiissnan:masterfrom
dolphinlin:ribbon-fix
Apr 30, 2017
Merged

fix ribbon cause scroll not working#1640
ivan-nginx merged 1 commit intoiissnan:masterfrom
dolphinlin:ribbon-fix

Conversation

@dolphinlin
Copy link
Copy Markdown
Contributor

@dolphinlin dolphinlin commented Apr 30, 2017

the code cause an exception.

  document.addEventListener("touchmove", function(e) {
    e.preventDefault()
  });

see that > JS MDN

@ivan-nginx
Copy link
Copy Markdown
Collaborator

ivan-nginx commented Apr 30, 2017

This is fix? All worked fine?

@dolphinlin
Copy link
Copy Markdown
Contributor Author

dolphinlin commented Apr 30, 2017

yeap!
remove the code from there, it works

@ivan-nginx
Copy link
Copy Markdown
Collaborator

ivan-nginx commented Apr 30, 2017

Ok, well done! And thanks!

@ivan-nginx ivan-nginx merged commit 4637429 into iissnan:master Apr 30, 2017
@ivan-nginx ivan-nginx mentioned this pull request Apr 30, 2017
Closed
@dolphinlin
Copy link
Copy Markdown
Contributor Author

dolphinlin commented Apr 30, 2017

i improved the performance.
i think the code that avoid redrawing background when touch screen to click or move.
click -> do to.
move -> don't to do.

so i add some judgment for improving performance

i need to PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dolphinlin @ivan-nginx