create tmp manifest file in same dir as dest to avoid issues with cross filesystem renameTo

igorbernstein2 · igorbernstein2 · commit 52e211bd112a · 2018-11-01T13:22:46.000-04:00
diff --git a/google-cloud-testing/google-cloud-gcloud-maven-plugin/src/main/java/com/google/cloud/DownloadComponentsMojo.java b/google-cloud-testing/google-cloud-gcloud-maven-plugin/src/main/java/com/google/cloud/DownloadComponentsMojo.java
@@ -177,10 +177,11 @@ private void updateCachedManifest() throws IOException {
 
     getLog().debug("Downloading fresh manifest");
 
-    File tempFile = File.createTempFile(localCache.getName(), "");
+    File tempFile = new File(localCache.toString() + ".tmp");
+    tempFile.createNewFile();
 
     try (BufferedInputStream in = new BufferedInputStream(manifestUrl.openStream());
-        FileOutputStream fileOutputStream = new FileOutputStream(tempFile)) {
+        FileOutputStream fileOutputStream = new FileOutputStream(tempFile, false)) {
       byte dataBuffer[] = new byte[1024];
       int bytesRead;
       while ((bytesRead = in.read(dataBuffer, 0, 1024)) != -1) {
