Skip to content

One top wall fixes#2

Closed
igiannakas wants to merge 1 commit into
igiannakas:dev-branchfrom
vovodroid:one-top-wall-fix
Closed

One top wall fixes#2
igiannakas wants to merge 1 commit into
igiannakas:dev-branchfrom
vovodroid:one-top-wall-fix

Conversation

@igiannakas

Copy link
Copy Markdown
Owner

Description

Screenshots/Recordings/Graphs

Tests

@igiannakas igiannakas closed this Jul 22, 2024
igiannakas pushed a commit that referenced this pull request Feb 25, 2025
* Add Zink Override

Add Zink Override

* Add Zink Override (#1)

Add Zink Override

* Fix escape literals

* Fix Escape Literals (#2)

* Add Zink Override

Add Zink Override

* Fix escape literals

* Add checks for wayland/render gpu and manual user overrides

---------

Co-authored-by: SoftFever <[email protected]>
igiannakas pushed a commit that referenced this pull request Oct 30, 2025
igiannakas added a commit that referenced this pull request Jan 6, 2026
commit 3b4600d
Author: SoftFever <[email protected]>
Date:   Tue Jan 6 18:19:50 2026 +0800

    fix some minor issues

commit 39df09b
Author: SoftFever <[email protected]>
Date:   Tue Jan 6 16:31:54 2026 +0800

    fix build errors

commit 1b355be
Merge: d681565 57dd572
Author: SoftFever <[email protected]>
Date:   Tue Jan 6 11:09:09 2026 +0800

    Merge branch 'main' into libvgcode

commit d681565
Merge: 1165c56 e4f6499
Author: Ioannis Giannakas <[email protected]>
Date:   Thu Dec 18 12:55:11 2025 +0000

    Merge branch 'main' into libvgcode

commit 1165c56
Merge: 9a30704 f3e486c
Author: Andrew Sun <[email protected]>
Date:   Tue Nov 25 15:19:57 2025 -0500

    Merge branch 'main' into libvgcode

commit 9a30704
Author: Kiss Lorand <[email protected]>
Date:   Tue Nov 25 19:25:03 2025 +0200

    GPU overdrive fix (#4)

commit 8d3b364
Merge: daf3038 3367648
Author: Noisyfox <[email protected]>
Date:   Sat Nov 22 19:35:32 2025 +0800

    Merge branch 'main' into libvgcode

commit daf3038
Merge: e4d354b 3a7309a
Author: Andrew Sun <[email protected]>
Date:   Fri Nov 21 08:47:25 2025 -0500

    Merge branch 'main' into libvgcode

commit e4d354b
Merge: a87df7f aa5350a
Author: Andrew Sun <[email protected]>
Date:   Tue Nov 18 19:53:58 2025 -0500

    Merge remote-tracking branch 'upstream/main' into libvgcode

    # Conflicts:
    #	src/libslic3r/GCode/GCodeProcessor.cpp

commit a87df7f
Author: Kiss Lorand <[email protected]>
Date:   Wed Nov 19 02:50:48 2025 +0200

    Bugfixes (#2)

    * Bugfixes

    * Reduce size of diff

    to avoid merge conflicts when we cherry-pick from upstream :)

    * remove extraneous space

    ---------

    Co-authored-by: Andrew Sun <[email protected]>

commit 2440d66
Merge: 7408f33 4046e39
Author: Ioannis Giannakas <[email protected]>
Date:   Mon Nov 17 17:48:25 2025 +0000

    Merge branch 'main' into libvgcode

commit 7408f33
Merge: 32ce749 4b1ddcd
Author: Andrew Sun <[email protected]>
Date:   Sun Nov 16 22:51:31 2025 -0500

    Merge remote-tracking branch 'upstream/main' into libvgcode

    # Conflicts:
    #	src/slic3r/GUI/GLCanvas3D.cpp

commit 32ce749
Author: Andrew Sun <[email protected]>
Date:   Sun Nov 16 11:34:56 2025 -0500

    Adjust shaders to increase shadows/contrast between layers

commit 8a1e0ee
Author: Morton Jonuschat <[email protected]>
Date:   Wed Apr 23 21:41:49 2025 -0700

    feat: Reduce size of option marker in G-Code preview

commit 7de779a
Author: Andrew Sun <[email protected]>
Date:   Sat Nov 15 12:00:24 2025 -0500

    Remove unnecessary requires_extra_frame call

commit fcdd3d3
Author: Andrew Sun <[email protected]>
Date:   Fri Nov 14 21:56:34 2025 -0500

    Don't hide some properties for non-extrusion moves

commit e0cdae0
Author: enricoturri1966 <[email protected]>
Date:   Thu Jun 20 02:46:15 2024 -0400

    SPE-2359: Added speed and volumetric flow rate to imgui vertex properties dialog (OrcaSlicer#12840)

    (cherry picked from commit 0602723)

commit 6e9fbc9
Author: Andrew Sun <[email protected]>
Date:   Mon Nov 10 18:38:33 2025 -0500

    Fix incorrect display of flow rate changes

commit bdbeb34
Author: Lukáš Hejl <[email protected]>
Date:   Fri Aug 16 08:35:49 2024 -0400

    Accumulate the total estimated print in doubles instead of floats.

    Because total print time is typically a big floating point number and the time of trapezoid is typically a small number, summing those numbers leads to a loss in precision. Switching to doubles reduces the loss of precision.

    (cherry picked from commit c5982f4)

commit bec883e
Author: Lukáš Hejl <[email protected]>
Date:   Fri Aug 16 08:04:51 2024 -0400

    SPE-2441: Fix discontinuity between the processed blocks' exit speed and the new first block's entry speed.

    This discontinuity affected both time estimation and actual speed visualization.

    (cherry picked from commit 90073dc)

commit acd3c94
Author: enricoturri1966 <[email protected]>
Date:   Wed Jul 17 05:24:01 2024 -0400

    SPE-2397: Fixed order of traversing time blocks in GCodeProcessor::TimeMachine::calculate_time() to match what is done in firmware

    (cherry picked from commit 9b7961d)

commit 7814605
Merge: fd22fc9 4501bf6
Author: Andrew Sun <[email protected]>
Date:   Sun Nov 9 18:48:04 2025 -0500

    Merge remote-tracking branch 'upstream/main' into libvgcode

    # Conflicts:
    #	src/libslic3r/GCode/GCodeProcessor.cpp
    #	src/libslic3r/GCode/GCodeProcessor.hpp
    #	src/slic3r/CMakeLists.txt
    #	src/slic3r/GUI/GCodeViewer.cpp
    #	src/slic3r/GUI/GCodeViewer.hpp
    #	src/slic3r/GUI/GLCanvas3D.cpp
    #	src/slic3r/GUI/GLCanvas3D.hpp
    #	src/slic3r/GUI/GUI_Preview.cpp

commit fd22fc9
Author: Andrew Sun <[email protected]>
Date:   Wed Sep 24 22:45:35 2025 -0400

    More OpenGL Core Profile fixes

commit cad8875
Author: Andrew Sun <[email protected]>
Date:   Wed Sep 24 22:18:40 2025 -0400

    Fix bed grid thin/thick lines in OpenGL Core Profile

commit 2cb5b02
Author: Andrew Sun <[email protected]>
Date:   Wed Sep 24 20:44:33 2025 -0400

    Fix crash in filament/color print view

commit 9bee057
Author: Andrew Sun <[email protected]>
Date:   Sun Sep 21 10:26:40 2025 -0400

    Fix auto-switch to color print view type

commit f8a7589
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 21:24:52 2025 -0400

    Clean up TODOs and commented out code

commit 8ed12a8
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 18:52:48 2025 -0400

    Styling changes for position window

commit 8552f2e
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 18:30:27 2025 -0400

    Wire up new position window from PrusaSlicer

commit 7271123
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 17:40:38 2025 -0400

    Fix incorrect feedrate for G2/G3 arcs

commit 1394a3c
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 17:40:12 2025 -0400

    Import PrusaSlicer G2/G3 arc discretization code

commit 20f132e
Author: enricoturri1966 <[email protected]>
Date:   Tue May 30 02:51:01 2023 -0400

    SPE-1739: Fixed calculation of gcode preview sequential slider endpoints

    (cherry picked from commit 5789212)

commit 25c19c9
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 15:10:06 2025 -0400

    Enable seam visibility by default

commit d539540
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 15:09:55 2025 -0400

    Add support for Orca-specific extrusion roles

commit 9359aa8
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 13:48:20 2025 -0400

    Fix nozzle marker position

commit f696d19
Author: Andrew Sun <[email protected]>
Date:   Sat Sep 20 13:22:38 2025 -0400

    Add seq_top_layer_only config default to fix moves slider

commit 2c34287
Author: Andrew Sun <[email protected]>
Date:   Mon Sep 15 21:01:54 2025 -0400

    Expose actual speed/actual volumetric speed view modes, misc fixes

commit c92328c
Author: Andrew Sun <[email protected]>
Date:   Mon Sep 15 03:17:10 2025 -0400

    Port libvgcode from PrusaSlicer 2.8.0

    Includes (but is not limited to) the following commits:

    SPE-2218 - libvgcode - Fixed color of wipe moves for speed range view
    SPE-2218 - libvgcode - Fixed detection of fan speed range
    SPE-2218 - libvgcode - Fixed detection of temperature range
    SPE-2218 - libvgcode - Fixed colors for Actual volumetric flow rate view
    SPE-2214 - Fixed detection of toolpaths bounding box in GCodeViewer
    SPE-2206 - Modified LibBGCode.cmake to get latest version of libbgcode which fixed parsing of gcode lines G4
    libvgcode - Fixed potential out of bound access in ViewerImpl::update_view_full_range()
    Tech ENABLE_GL_CORE_PROFILE set as default
    Tech ENABLE_OPENGL_ES replaced by build option SLIC3R_OPENGL_ES
    libvgcode - Precompiler definition of ENABLE_OPENGL_ES moved into CMakeLists.txt
    Added missing include
    libvgcode - Textures setup modified to work when building using emscripten
    libvgcode - small optimization
    libvgcode - fixed OpenGLWrapper::unload_opengl()
    libvgcode - CMakeLists.txt modified to work with emscripten
    libvgcode - Replace 'glVertexAttribIPointer()' with 'glVertexAttribPointer()' in SegmentTemplate::init() for OpenGL ES
    libvgcode - Replace 'xor' with '^' Bitset.hpp
    libvgcode - Newer glad library for OpenGL 4.6 and OpenGL ES 3.0
    libvgcode - Alternate fix in method ViewerImpl::update_heights_widths() for OpenGL ES
    libvgcode - Fixes in glAssertRecentCallImpl()
    libvgcode - Fixes in method ViewerImpl::update_heights_widths() for OpenGL ES
    Fixed ES shaders so they work with OpenGL ES 3.0
    libvgcode - Use multiple plain textures in place of texture buffers for OpenGL ES
    libvgcode - Use plain textures in place of texture buffers for OpenGL ES (partial implementation using one texture per buffer)
    libvgcode - refactoring of class OpenGLWrapper
    libvgcode - small refactoring in shaders
    libvgcode - replacement of glMapBuffer() call for OpenGL ES
    Fixed warning
    libvgcode - Changes into CMakeLists.txt
    Fixed debug export of gcode data to be configuration indipendent
    Disabled tech ENABLE_NEW_GCODE_VIEWER_DEBUG
    Removed obsolete tech ENABLE_GCODE_VIEWER_DATA_CHECKING
    Code cleanup and techs removal - completed
    Code cleanup and techs removal - step 1
    SPE-1872: Implemented G2/G3 lines discretization for gcfMarlinFirmware firmware flavour
    SPE-1872: Corrections into GCodeProcessor::process_G2_G3() to match firmware code
    SPE-1872: Actual speed profile - Further enhancements of imgui debug window
    SPE-1872: Actual speed profile - Rework in its calculation + enhanced imgui debug window
    SPE-1872: New imgui widget to show actual speed profile
    SPE-1872: Fixed actual speed for seam moves and at extrusion/travel/wipe start
    SPE-1872: Fixed rendering of wipe moves when actual speed view is selected
    SPE-1872: Actual speed profile extended to travel and wipe moves
    SPE-1872: Fixes in function recalculate_trapezoids() and method GCodeProcessor::TimeMachine::calculate_time() to smooth actual speed profile
    SPE-1872: Added debug graphic to show move actual speed profile
    SPE-1872: libvgcode library: replace volumetric flow rate data with mm3_per_mm to reduce memory usage
    SPE-1872: Added visualization of actual volumetric flow rate
    SPE-1872: Fixes in calculating actual speed
    SPE-1872: Added visualization of actual speed in gcode preview
    SPE-2124: Added command line option 'opengl-aa' to allow the user to turn on the automatic selection of max number of supported samples for OpenGL antialising
    OrcaSlicer#12117: Reduced moire patterns by using the highest number of samples available for multisampling
    New gcode visualization integration - Partially enabled imgui debug window
    New gcode visualization integration - Fixed center of gravity calculation and rendering
    New gcode visualization library - Interface for estimated times
    New gcode visualization library - Tool marker rendering
    New gcode visualization library - Axes aligned bounding boxes calculation
    Removed obsolete debug code
    New gcode visualization library - Added statistic of used memory
    New gcode visualization library - Separation of tool colors and color changes colors to simplify client code
    Added missing include
    New gcode visualization library - Added print color changes detection
    New gcode visualization library - Modified OpenGL ES context detection
    New gcode visualization library - Another makefile cleanup
    New gcode visualization library - Makefiles cleanup
    New gcode visualization library - Added suppression of error 'This function or variable may be unsafe' in VS2022
    New gcode visualization library - Compatibility with OpenGL ES
    New gcode visualization library - Interface cleanup and documentation
    New gcode visualization library - Extended interface to give access to estimated times
    New gcode visualization integration - Toggling of top layer only view state
    New gcode visualization integration - Removed imperial units from tool position data
    Small refactoring
    New gcode visualization library - Custom values for travel and wipe moves radius
    New gcode visualization library - Allow customization of range colors
    New gcode visualization library - Partial update of interface comments/documentation
    New gcode visualization integration - Follow-up of 35ee55e29bb231fd01a2eb71ae293832a37ca65d - Better fix for toolpaths visible range when toggling options' visibility
    New gcode visualization integration - Fixed toolpaths reset
    New gcode visualization library - Fixed method set_option_color()
    New gcode visualization library - Fixed method ViewerImpl::set_extrusion_role_color()
    New gcode visualization library - Added methods to release gpu resources on demand.
    New gcode visualization library - Travel and wipe moves as options
    New gcode visualization integration - Fixed toolpaths visible range when toggling options' visibility
    New gcode visualization integration - Fixed management of gcode preview view type
    New gcode visualization - Fixed wrong include
    New gcode visualization - Added missing headers
    New gcode visualization - Refactoring + added missing headers
    New gcode visualization - New code set as standalone library + embed glad library to load OpenGL functions
    New gcode visualization - Fixed errors and warnings when building the new code as a standalone library
    New gcode visualization integration - Fixed layers ordering in pre-gcode preview
    New gcode visualization integration - Fixed objects' tool colors in pre-gcode preview
    Code cleanup
    New gcode visualization integration - Tool position properties data window
    New gcode visualization integration - Fixed in export toolpaths to obj
    New gcode visualization - Inlining in source code
    Refactoring
    New gcode visualization integration - Export toolpaths to obj
    Some refactoring and warning fix
    New gcode visualization integration - Customizable travel moves colors
    New gcode visualization integration - Customizable options colors
    New gcode visualization integration - Customizable extrusion roles colors
    New gcode visualization integration - Fixed pre-gcode preview layers times
    New gcode visualization integration - Modify pre-gcode preview to use the new toolpaths renderer, objects WIP
    New gcode visualization - Modify pre-gcode preview to use the new toolpaths renderer, WIP (brim/skirt/wipe tower)
    New gcode visualization integration - Do not reset visible range when toggling options/roles visibility
    New gcode visualization - Fixed color of first vertex of top layer (when top layer only option is enabled)
    New gcode visualization - Customizable travels and wipes segment radius
    New gcode visualization integration - Removed tech ENABLE_GCODE_VIEWER_STATISTICS
    New gcode visualization integration - Added check of OpenGL version
    New gcode visualization integration - Removed GCodeProcessorResult::spiral_vase_layers
    Another bunch of warnings fixes
    Fixed warnings
    New gcode visualization integration - Removal of old visualization
    Fixed includes
    New gcode visualization integration - File structure of new code separated in api + src
    New gcode visualization integration - View ranges management moved to new visualizer
    New gcode visualization integration - Fixed top layer only visualization for MMU printers
    New gcode visualization integration - Removed dependency on imgui from new visualizer
    Some refactoring
    New gcode visualization integration - Removed dependency on Slic3r::GCodeProcessorResult from new visualizer
    New gcode visualization integration - Moves' data conversion moved to client side
    New gcode visualization: layers times refactoring
    A bunch of fixes for the new gcode visualization
    New gcode visualization: render in gray color layers containing pause print or custom gcode options when in Color Print view
    New gcode visualization integration - Tool colors
    New gcode visualization integration - Layers times
    New gcode visualization integration - Travels and Extrusion roles times
    Fixed detection of start/end of contiguous extrusion paths
    New gcode visualization integration - Extrusion roles
    New gcode visualization integration - Colors
    New gcode visualization integration - Tool position
    Center of gravity and tool marker may both be rendered with fixed screen size and a scaling factor
    Fixed rendering of options in new gcode visualization
    Tool marker NOT rendered by the new visualization code
    Center of gravity marker NOT rendered by the new visualization code
    Fixed toolpaths_cog shaders
    Tool position window for new gcode visualization
    Top layer only coloring for neww gcode visualization
    Refactoring in preview's new visualization
    Hidden imgui debug dialog for new visualization in preview
    Synchronization of moves between old and new visualization
    Fixed missing gcode window in new visualization
    Rendering of debug imgui dialog moved from class libvgcode::Viewer to class libvgcode::Toolpaths + warnings fixing
    Some functionality moved from class libvgcode::Viewer to class libvgcode::Toolpaths
    Some refactoring and cleanup
    Refatoring of PathVertex and Toolpaths::load()
    SPE-1982: Tech ENABLE_NEW_GCODE_VIEWER - 1st installment of new toolpaths rendering code (WIP)
igiannakas pushed a commit that referenced this pull request Jan 6, 2026
* Bugfixes

* Reduce size of diff

to avoid merge conflicts when we cherry-pick from upstream :)

* remove extraneous space

---------

Co-authored-by: Andrew Sun <[email protected]>
igiannakas pushed a commit that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants