Repository navigation
Commit 6f2f61c
committed
fix(cli): remove the OpenShell first-poll settle wait
fullsend run waited up to 12s after sandbox creation
(openShellFirstPollSettle) to work around NVIDIA/OpenShell#3809: on
OpenShell 0.1.2 the supervisor's first settings poll reloaded the
policy and cut in-flight connections. The upstream fix
(NVIDIA/OpenShell#3819) ships in 0.1.3+, and fullsend now pins 0.1.4
in .github/scripts/openshell-version.sh, so every run paid the wait
for nothing.
- Delete internal/cli/openshell_settle.go and its test.
- runAgent: drop the sandboxReadyAt anchor and the 9b-1 wait block.
The 9b-2 label is left as is.
- hack/gitlab-runner-vm: bump the fallback OPENSHELL_VERSION (used
only when the pin file is absent) from 0.1.2 to 0.1.4 in
create-gcp-vm.sh, create-openshift-vm.sh and setup.sh.
- Correct the runner-VM README and setup.sh header: prepare.sh
installs the job image's OpenShell only when it equals the host pin
and fails the job otherwise, so a stale VM pin does not self-heal.
After a bump, re-run create-*-vm.sh --resume NUMBER from an updated
checkout.
Note: pre-commit could not fetch remote hook repos (TLS verification
failed in the sandbox), so the hooks were run directly: whitespace,
EOF, conflict, CRLF checks, shellcheck 0.10.0, gofmt, go vet,
lint-broken-symlinks and lychee all passed; gitleaks was covered by
scan-secrets. go test ./internal/cli/ has six failures that also fail
on main in this sandbox (TestStartFetchService_* cannot dial
localhost; TestPostScriptEnv_NoSchemaAppended* see the sandbox's
FULLSEND_OUTPUT_SCHEMA and pass with it unset).
Closes fullsend-ai#85311 parent 07bb0ea commit 6f2f61c
7 files changed
Lines changed: 9 additions & 190 deletions
File tree
- hack/gitlab-runner-vm
- internal/cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
| 315 | + | |
316 | 316 | | |
317 | 317 | | |
318 | 318 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
61 | | - | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1923 | 1923 | | |
1924 | 1924 | | |
1925 | 1925 | | |
1926 | | - | |
1927 | | - | |
1928 | | - | |
1929 | 1926 | | |
1930 | 1927 | | |
1931 | 1928 | | |
| |||
2420 | 2417 | | |
2421 | 2418 | | |
2422 | 2419 | | |
2423 | | - | |
2424 | | - | |
2425 | | - | |
2426 | | - | |
2427 | | - | |
2428 | | - | |
2429 | | - | |
2430 | 2420 | | |
2431 | 2421 | | |
2432 | 2422 | | |
| |||
0 commit comments