feat: show available sdo groups to liaison coordinators and managers #9856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9856 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 316 316
Lines 42265 42264 -1
==========================================
- Hits 37423 37421 -2
- Misses 4842 4843 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
requested changes
Nov 4, 2025
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Minor cleanup probably worth doing to maintain best practices: remove the import Tuple and use tuple[str, str]. Otherwise looks good.
ietf/templates/base/menu.html
Outdated
| </li> | ||
| {% if user|has_role:"Secretariat,IAB,Liaison Manager,Liaison Coordinator" %} | ||
| <li> | ||
| <a class="dropdown-item {% if flavor != 'top' %}text-wrap{% endif %}" |
Member
There was a problem hiding this comment.
Ultra-tiny nit: avoid trailing space when flavor == 'top'
Suggested change
| <a class="dropdown-item {% if flavor != 'top' %}text-wrap{% endif %}" | |
| <a class="dropdown-item{% if flavor != 'top' %} text-wrap{% endif %}" |
Member
Author
There was a problem hiding this comment.
this had been keeping the same format as the other dozen versions of it around it, but I added a commit that changed them all (expanding the scope of the PR a bit).
jennifer-richards
approved these changes
Nov 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.