Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micropub Endpoint creates checkin if mp-type == checkin #1249

Merged
merged 4 commits into from
Feb 17, 2016

Conversation

@danito
Copy link
Contributor Author

danito commented Feb 17, 2016

I hope I got it right this time. (OT how can I get rid off those unnecessary commits when PR?)

benwerd added a commit that referenced this pull request Feb 17, 2016
Micropub Endpoint creates checkin if mp-type == checkin
@benwerd benwerd merged commit e0da250 into idno:master Feb 17, 2016
@kylewm
Copy link
Collaborator

kylewm commented Feb 17, 2016

Looks good to me!

how can I get rid off those unnecessary commits when PR?

git rebase -i origin/master is useful here -- it gives you the option to squash commits with their predecessor, so you can just change all but the first "pick" to "squash". if you've already pushed the branch, then you'll need to force push since this rewrites history.

but really if it's just a few commits, it's usually not necessary to squash them. i only get picky when there are a ton of commits, or they make and then undo unrelated changes (because it makes the version history confusing)

also: I'd recommend working in a branch git checkout -b <branchname> when you're putting together a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

micropub checkins not working
3 participants