Fix Witness Calculator to be compatible with Circom 2#14
Merged
jbaylina merged 5 commits intoiden3:masterfrom Jan 17, 2022
nalinbhardwaj:master
Merged
Fix Witness Calculator to be compatible with Circom 2#14jbaylina merged 5 commits intoiden3:masterfrom nalinbhardwaj:master
jbaylina merged 5 commits intoiden3:masterfrom
nalinbhardwaj:master
Conversation
phated
reviewed
Jan 11, 2022
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
A bunch of questions. I wonder if we won't need separate code paths based on the exports.
This was referenced Jan 11, 2022
Contributor
Author
|
Rebased on new master and ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated witness calculator for compatibility with Circom 2. I'm not quite familiar with internal circom code, but I've mostly written this with https://github.com/iden3/circom and https://github.com/nalinbhardwaj/snarkjs as reference. For testing, I've pretty much only made sure browser
fullProveand verification work when using snarkjs. Not sure if there's anything else that should be tested.My personal fork that was tested is in https://github.com/nalinbhardwaj/snarkjs using a modified circuit from https://github.com/nalinbhardwaj/snarky-sudoku
Fixes iden3/snarkjs#107