Some additional changes#1
Merged
icexelloss merged 6 commits intoicexelloss:refactor-r-windowfrom Apr 4, 2023
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
icexelloss
approved these changes
Apr 4, 2023
westonpace
added a commit
that referenced
this pull request
Apr 5, 2023
* Making Acero off on minimal builds. Adding 'skip if no snappy' to parquet test that needs snappy. * Various changes to allow R to build without acero * Skipping query engine tests if acero not enabled * Disabling example that depended on Acero if Acero is not enabled * Add arrow_with_acero function * Turns out @examplesIf has to replace @examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these I can (I think) get the r-minimal-build to pass.