Repository navigation
Commit 653a373
committed
compat(agent): verify Codex Room approval and pin codex-acp 1.12.0 (i365dev#426)
The old pin could not do this at all: its command approval carried no
presentation metadata, so the Runtime refused the request before any Room
request existed. i365dev#429 fixed the Free4Chat projection defect; this re-runs the
compatibility acceptance against the released bridge and moves the pin.
Verified against codex-acp 1.12.0 with Codex/app-server 0.154.0 in Free4Chat's
explicit read-only mode, through a REAL browser Room on the real Worker and
RoomSession Durable Object:
command an out-of-workspace command produced a Room approval card carrying
the exact command, cwd and all three native options. Selecting
accept_execpolicy_amendment - whose native label exceeds the Room
presentation budget and is therefore bounded by i365dev#429 - ran the
command and the same turn continued; selecting cancel ran nothing
and the session stayed usable. The exact native OptionID
round-tripped untouched and no display text was used as identity.
file an edit outside the writable root produced an EDIT Room card
offering allow_once / allow_for_session / cancel; allow applied the
edit, reject left the file unchanged, and the session stayed usable.
Approval stays PARTIAL, deliberately scoped: openai/codex#21982 (sandbox
permissions / require_escalated surfacing), agentclientprotocol/codex-acp#310
(mode/config coupling) and i365dev#401 (MCP execution mediation) all remain open, and
no MCP path or alternate sandbox/mode combination was exercised.
Execution stays SERIAL with one lane, SessionContinuation stays unchanged, and
no generic Runtime Task control is touched. No Agent release is published
here.1 parent ce64537 commit 653a373
4 files changed
Lines changed: 60 additions & 18 deletions
File tree
- agent/internal/harness
- app/public
- docs/en/concepts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
93 | 119 | | |
94 | 120 | | |
95 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
760 | 760 | | |
761 | 761 | | |
762 | 762 | | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | | - | |
767 | | - | |
768 | | - | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
769 | 777 | | |
770 | 778 | | |
771 | 779 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
56 | 64 | | |
57 | 65 | | |
58 | 66 | | |
| |||
0 commit comments