Skip to content

Commit 653a373

Browse files
committed
compat(agent): verify Codex Room approval and pin codex-acp 1.12.0 (i365dev#426)
The old pin could not do this at all: its command approval carried no presentation metadata, so the Runtime refused the request before any Room request existed. i365dev#429 fixed the Free4Chat projection defect; this re-runs the compatibility acceptance against the released bridge and moves the pin. Verified against codex-acp 1.12.0 with Codex/app-server 0.154.0 in Free4Chat's explicit read-only mode, through a REAL browser Room on the real Worker and RoomSession Durable Object: command an out-of-workspace command produced a Room approval card carrying the exact command, cwd and all three native options. Selecting accept_execpolicy_amendment - whose native label exceeds the Room presentation budget and is therefore bounded by i365dev#429 - ran the command and the same turn continued; selecting cancel ran nothing and the session stayed usable. The exact native OptionID round-tripped untouched and no display text was used as identity. file an edit outside the writable root produced an EDIT Room card offering allow_once / allow_for_session / cancel; allow applied the edit, reject left the file unchanged, and the session stayed usable. Approval stays PARTIAL, deliberately scoped: openai/codex#21982 (sandbox permissions / require_escalated surfacing), agentclientprotocol/codex-acp#310 (mode/config coupling) and i365dev#401 (MCP execution mediation) all remain open, and no MCP path or alternate sandbox/mode combination was exercised. Execution stays SERIAL with one lane, SessionContinuation stays unchanged, and no generic Runtime Task control is touched. No Agent release is published here.
1 parent ce64537 commit 653a373

4 files changed

Lines changed: 60 additions & 18 deletions

File tree

‎agent/internal/harness/provider_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func TestBuiltInProvidersMatchPreviousLauncherPolicy(t *testing.T) {
4343
execution: types.TaskExecutionPolicy{Probe: types.TaskExecutionProbeConcurrencyObserved, Concurrency: types.TaskExecutionSerial},
4444
},
4545
{
46-
id: "codex", command: "npx", args: []string{"-y", "@agentclientprotocol/codex-acp@1.6.2"},
46+
id: "codex", command: "npx", args: []string{"-y", "@agentclientprotocol/codex-acp@1.12.0"},
4747
env: map[string]string{"INITIAL_AGENT_MODE": "read-only"},
4848
maturity: types.MaturityBridge, security: types.SecurityTrustedRoom,
4949
continuation: false,

‎agent/internal/harness/providers.go‎

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ var builtInProviders = []Provider{
6868
ID: "codex",
6969
DisplayName: "Codex",
7070
Command: "npx",
71-
Args: []string{"-y", "@agentclientprotocol/codex-acp@1.6.2"},
71+
Args: []string{"-y", "@agentclientprotocol/codex-acp@1.12.0"},
7272
Maturity: types.MaturityBridge,
7373
Security: types.SecurityTrustedRoom,
7474
Environment: map[string]string{"INITIAL_AGENT_MODE": "read-only"},
@@ -86,10 +86,36 @@ var builtInProviders = []Provider{
8686
Mode: types.TaskExecutionSerial,
8787
Evidence: types.TaskExecutionProbeConcurrencyObserved,
8888
},
89-
// #297 recorded a bridge/app-server/policy limitation; whether the
90-
// current pinned bridge emits ACP permission requests is being
91-
// re-verified in #426. Until that result exists this stays PARTIAL
92-
// instead of an optimistic upgrade or a permanent "unsupported".
89+
// #426 re-verification against codex-acp 1.12.0 + Codex 0.154.0 in
90+
// explicit read-only mode, through a REAL browser Room:
91+
//
92+
// command an out-of-workspace `touch` produced a Room approval
93+
// card carrying the exact command, cwd, and all three
94+
// native options. Selecting
95+
// `accept_execpolicy_amendment` — whose native label
96+
// exceeds the Room presentation budget and is therefore
97+
// bounded by #429 — ran the command and the same turn
98+
// continued; selecting `cancel` ran nothing and the
99+
// session stayed usable. The exact native OptionID
100+
// round-tripped untouched, and no display text was used
101+
// as identity.
102+
// file an edit outside the writable root produced an EDIT
103+
// Room card offering allow_once / allow_for_session /
104+
// cancel. The ACP round trip was verified end-to-end:
105+
// allow edits the file, reject leaves it unchanged, and
106+
// the same native session remains usable.
107+
//
108+
// The previous 1.6.2 pin could not do this at all: its command
109+
// request carried no presentation metadata, so the Runtime refused
110+
// it before any Room request existed.
111+
//
112+
// It stays PARTIAL because this verification is deliberately
113+
// SCOPED. openai/codex#21982 (sandbox_permissions /
114+
// require_escalated surfacing), agentclientprotocol/codex-acp#310
115+
// (mode/config coupling) and #401 (MCP execution mediation) all
116+
// remain OPEN, and no MCP path or alternate sandbox/mode
117+
// combination was exercised. Only the ordinary command and
118+
// file-change paths in read-only mode are verified.
93119
Approval: ApprovalPartial,
94120
},
95121
},

‎app/public/llms-full.txt‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -760,12 +760,20 @@ native policy decide whether an ACP permission request is emitted.
760760

761761
### Codex
762762

763-
Current Codex ACP behavior has an upstream bridge/policy limitation. Native
764-
Codex can prompt under stricter policies such as `untrusted`, but the tested
765-
`codex-acp` modes do not currently expose that path cleanly to Free4Chat. This
766-
is a compatibility limitation in the upstream bridge/policy path, not a
767-
Free4Chat Room approval failure. No vendor-specific workaround is required by
768-
the Room permission model.
763+
Codex Room approval is **verified for the ordinary command and file-change
764+
paths** on `codex-acp` 1.12.0 with Codex/app-server 0.154.0 in Free4Chat's
765+
explicit `read-only` mode: a real browser Room showed the approval card, the
766+
Human's choice was returned as the exact native option id, an approved command
767+
ran and the same turn continued, and a rejected command or file change did not
768+
happen while the session stayed usable.
769+
770+
It remains **partial**, and deliberately scoped. Upstream issues are still open
771+
for paths this verification did not exercise: `sandbox_permissions` /
772+
`require_escalated` surfacing (openai/codex#21982), bridge mode/config coupling
773+
(agentclientprotocol/codex-acp#310), and MCP execution mediation
774+
(agentclientprotocol/codex-acp#401). Nothing here generalizes to MCP calls or
775+
to every Codex sandbox/mode combination, and no vendor-specific workaround is
776+
required by the Room permission model.
769777

770778
### OpenCode, Hermes, and Pi
771779

‎docs/en/concepts/agent-permissions.md‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,20 @@ native policy decide whether an ACP permission request is emitted.
4747

4848
### Codex
4949

50-
Current Codex ACP behavior has an upstream bridge/policy limitation. Native
51-
Codex can prompt under stricter policies such as `untrusted`, but the tested
52-
`codex-acp` modes do not currently expose that path cleanly to Free4Chat. This
53-
is a compatibility limitation in the upstream bridge/policy path, not a
54-
Free4Chat Room approval failure. No vendor-specific workaround is required by
55-
the Room permission model.
50+
Codex Room approval is **verified for the ordinary command and file-change
51+
paths** on `codex-acp` 1.12.0 with Codex/app-server 0.154.0 in Free4Chat's
52+
explicit `read-only` mode: a real browser Room showed the approval card, the
53+
Human's choice was returned as the exact native option id, an approved command
54+
ran and the same turn continued, and a rejected command or file change did not
55+
happen while the session stayed usable.
56+
57+
It remains **partial**, and deliberately scoped. Upstream issues are still open
58+
for paths this verification did not exercise: `sandbox_permissions` /
59+
`require_escalated` surfacing (openai/codex#21982), bridge mode/config coupling
60+
(agentclientprotocol/codex-acp#310), and MCP execution mediation
61+
(agentclientprotocol/codex-acp#401). Nothing here generalizes to MCP calls or
62+
to every Codex sandbox/mode combination, and no vendor-specific workaround is
63+
required by the Room permission model.
5664

5765
### OpenCode, Hermes, and Pi
5866

0 commit comments

Comments
 (0)