Replace np.product with np.prod due to deprecation#385
Merged
Conversation
Closed
btjanaka
added a commit
that referenced
this pull request
Sep 25, 2023
<!-- Provide a brief description of the PR's purpose here. --> `np.product` is deprecated in numpy 1.25.0 -- see numpy/numpy#23314 This PR replaces our calls to `np.product` with `np.prod`. <!-- Notable points that this PR has either accomplished or will accomplish. --> <!-- Any concerns or points of confusion? --> - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
np.productis deprecated in numpy 1.25.0 -- see numpy/numpy#23314This PR replaces our calls to
np.productwithnp.prod.TODO
Questions
Status
CONTRIBUTING.md
yapfpytestpylintHISTORY.md