Skip to content

Fix translations in appdata file#5

Closed
jbicha wants to merge 1 commit intoibus:masterfrom
jbicha:master
Closed

Fix translations in appdata file#5
jbicha wants to merge 1 commit intoibus:masterfrom
jbicha:master

Conversation

@jbicha
Copy link
Copy Markdown

@jbicha jbicha commented Mar 16, 2017

ibus-anthy 1.5.9's appdata file is broken on Ubuntu 17.04 Beta.

In gnome-software the ibus-anthy description is in Ukrainian.

http://appstream.ubuntu.com/zesty/main/issues/ibus-anthy.html

Compare with gedit's appstream file.

The Anthy input method is designed for entering Japanese text.
</p>
<p>
<_/p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be </_p> but not <_/p>.

out on a traditional keyboard.
</p>
</_description>
<_/p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be </_p> but not <_/p>.

@fujiwarat
Copy link
Copy Markdown
Member

Also interested in another warning:

Validation of the metainfo file found a problem: The component ID is no reverse domain-name.

What is reverse domain-name?

@jbicha
Copy link
Copy Markdown
Author

jbicha commented Mar 16, 2017

Feel free to fix my commit and push if you like. Or do you want me to fix it?

As far as I know, the reverse domain name isn't mandatory. Some examples on my computer are org.gnome.gedit and org.gnome.Calculator. Now there isn't really a http://gedit.gnome.org or even http://gnome.org/gedit/ but the reverse domain name helps to control the namespace. Nothing else should use org.gnome.Calculator unless they are from the same group responsible for http://gnome.org/

There isn't really an ibus website, right? So you could use com.github.IBus.Anthy (capitalized or not is fine)

@fujiwarat
Copy link
Copy Markdown
Member

Thanks.
We have used org.freedesktop.ibus in dbus name and probably I will name it to keep the back compatibility.

OK, now I committed fujiwarat@7a99df9
I use fujiwarat/ibus-anthy repo for the devel purpose and it will be merged to ibus/ibus-anthy later.
I asked to modify your patch if you wish to contribute the ibus-anthy commit.

@fujiwarat fujiwarat closed this Mar 17, 2017
@jbicha
Copy link
Copy Markdown
Author

jbicha commented Mar 18, 2017

fujiwarat added a commit that referenced this pull request Mar 19, 2018
Fixed a warning in ibus-anthy.appdata.xml (#5)
Fix page_up, page_down, candidate_clicked (#6)
Fixed circle_typing_method for Alt-Romaji, Ctrl-/
Added Shift-F7 shortcut key to convert all to Katanaka
tests: Add automation testing
Migrated DConf to GSettings
Added ISSUE_TEMPLATE (fujiwarat) e0e6492
Added po/es.po po/cs.po
Updated emoji dictionary for Unicode 10 and emoji 5.0
Updated emoji dictionary for emoji 11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants