Closed
Conversation
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 6, 2025
Add `G_GNUC_UNUSED` flag for the GCC warnings. BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 6, 2025
Wish to run ibus-daemon after run ibus-ui-gtk3 for the debug purpose. BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 6, 2025
- When malloc() is failed, the pointer should not be deallocated and also other allocated memory pointers should be freed in FrameMgr.c. - The `XIM_STRFUNC` macro implemented in XimProto.h. - GCC `-Wanalyzer-malloc-leak` flag does not have to warn the reallocation since the `address` pointer is not changed and `address->imvalue_mask` should work in i18nMethod.c - Seems GCC does not understand `if (!p->value)` and replace it with a wrapper variable in i18nMethod.c - Fix exit() from within signal handler by CWE-479 and `-Wanalyzer-unsafe-call-within-signal-handler` in client/x11/main.c BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 6, 2025
Fix leaks of GOptionContext in bus/main.c BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 13, 2025
Fix leaks of GOptionContext in bus/main.c Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c BUG=ibus#2805
ec9cc4c to
50ba621
Compare
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Oct 14, 2025
- Fix leaks of GOptionContext in bus/main.c - Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c - Fix leaks of IBusTextClass:copy(), which is used in Emojier:get_one_dimension_lookup_table(), in src/ibustext.c - Fix leak of IBusExtensionEvent with commit-text signal and clicking close button since it's not floating in ui/gtk3/panelbinding.vala Fixes: ibus@a800957 BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Nov 26, 2025
- When malloc() is failed, the pointer should not be deallocated and also other allocated memory pointers should be freed in FrameMgr.c. - The `XIM_STRFUNC` macro implemented in XimProto.h. - GCC `-Wanalyzer-malloc-leak` flag does not have to warn the reallocation since the `address` pointer is not changed and `address->imvalue_mask` should work in i18nMethod.c - Seems GCC does not understand `if (!p->value)` and replace it with a wrapper variable in i18nMethod.c - Fix exit() from within signal handler by CWE-479 and `-Wanalyzer-unsafe-call-within-signal-handler` in client/x11/main.c BUG=ibus#2805
fujiwarat
added a commit
to fujiwarat/ibus
that referenced
this pull request
Nov 26, 2025
- Fix leaks of GOptionContext in bus/main.c - Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c - Fix leaks of IBusTextClass:copy(), which is used in Emojier:get_one_dimension_lookup_table(), in src/ibustext.c - Fix leak of IBusExtensionEvent with commit-text signal and clicking close button since it's not floating in ui/gtk3/panelbinding.vala Fixes: ibus@a800957 BUG=ibus#2805
- When malloc() is failed, the pointer should not be deallocated and also other allocated memory pointers should be freed in FrameMgr.c. - The `XIM_STRFUNC` macro implemented in XimProto.h. - GCC `-Wanalyzer-malloc-leak` flag does not have to warn the reallocation since the `address` pointer is not changed and `address->imvalue_mask` should work in i18nMethod.c - Seems GCC does not understand `if (!p->value)` and replace it with a wrapper variable in i18nMethod.c - Fix exit() from within signal handler by CWE-479 and `-Wanalyzer-unsafe-call-within-signal-handler` in client/x11/main.c BUG=ibus#2805
- Fix leaks of GOptionContext in bus/main.c - Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c - Fix leaks of IBusTextClass:copy(), which is used in Emojier:get_one_dimension_lookup_table(), in src/ibustext.c - Fix leak of IBusExtensionEvent with commit-text signal and clicking close button since it's not floating in ui/gtk3/panelbinding.vala Fixes: ibus@a800957 BUG=ibus#2805
fujiwarat
added a commit
that referenced
this pull request
Dec 9, 2025
Add `G_GNUC_UNUSED` flag for the GCC warnings. BUG=#2805
fujiwarat
added a commit
that referenced
this pull request
Dec 9, 2025
Wish to run ibus-daemon after run ibus-ui-gtk3 for the debug purpose. BUG=#2805
fujiwarat
added a commit
that referenced
this pull request
Dec 9, 2025
- When malloc() is failed, the pointer should not be deallocated and also other allocated memory pointers should be freed in FrameMgr.c. - The `XIM_STRFUNC` macro implemented in XimProto.h. - GCC `-Wanalyzer-malloc-leak` flag does not have to warn the reallocation since the `address` pointer is not changed and `address->imvalue_mask` should work in i18nMethod.c - Seems GCC does not understand `if (!p->value)` and replace it with a wrapper variable in i18nMethod.c - Fix exit() from within signal handler by CWE-479 and `-Wanalyzer-unsafe-call-within-signal-handler` in client/x11/main.c BUG=#2805
fujiwarat
added a commit
that referenced
this pull request
Dec 9, 2025
- Fix leaks of GOptionContext in bus/main.c - Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c - Fix leaks of IBusTextClass:copy(), which is used in Emojier:get_one_dimension_lookup_table(), in src/ibustext.c - Fix leak of IBusExtensionEvent with commit-text signal and clicking close button since it's not floating in ui/gtk3/panelbinding.vala Fixes: a800957 BUG=#2805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the changes are critical in the RC phase, the milestone will be 1.5.34.