ibus python binding wasn't working due to incorrect forward-key-event signature#2
Merged
phuang merged 1 commit intoibus:masterfrom Jun 8, 2011
Merged
ibus python binding wasn't working due to incorrect forward-key-event signature#2phuang merged 1 commit intoibus:masterfrom
phuang merged 1 commit intoibus:masterfrom
Conversation
phuang
added a commit
that referenced
this pull request
Jun 8, 2011
ibus python binding wasn't working due to incorrect forward-key-event signature
Author
|
thanks for merging!! |
fujiwarat
added a commit
that referenced
this pull request
Jan 29, 2012
BUG=none TEST=Linux desktop Review URL: https://codereview.appspot.com/5578054
fujiwarat
added a commit
that referenced
this pull request
Jan 20, 2016
Fix a build failure with make check. Review URL: https://codereview.appspot.com/285910043
fujiwarat
added a commit
that referenced
this pull request
Dec 4, 2019
fujiwarat
added a commit
that referenced
this pull request
Jan 12, 2025
Building your own marshaller list is most of the way there to get better signal performance, but you can go a bit further by having it generate va_marshallers and set those too. Not only do va_marshallers allow you to avoid the GValue boxing, it allows you to also get better profiling data at runtime. Fixes: c13c54e BUG=#2683
fujiwarat
added a commit
that referenced
this pull request
Dec 9, 2025
- Fix leaks of GOptionContext in bus/main.c - Fix leaks of IBusEngineDesc when IME is switched in client/wayland/ibuswaylandim.c - Fix leaks of IBusTextClass:copy(), which is used in Emojier:get_one_dimension_lookup_table(), in src/ibustext.c - Fix leak of IBusExtensionEvent with commit-text signal and clicking close button since it's not floating in ui/gtk3/panelbinding.vala Fixes: a800957 BUG=#2805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I corrected according to corresponding ibus C binding:
http://ibus.googlecode.com/svn/docs/ibus/IBusEngine.html#ibus-engine-forward-key-event