feat(api): add catalog and database kwargs to ibis.table#8801
Merged
cpcloud merged 1 commit intoibis-project:mainfrom Mar 28, 2024
Merged
feat(api): add catalog and database kwargs to ibis.table#8801cpcloud merged 1 commit intoibis-project:mainfrom
catalog and database kwargs to ibis.table#8801cpcloud merged 1 commit intoibis-project:mainfrom
Conversation
gforsyth
force-pushed
the
unbound_namespace
branch
2 times, most recently
from
43a9f16 to
e89ced0
Compare
Member
|
Looks like rogue parenthesis decided it didn't need to exist! |
This allows specifying 1 or 2 levels of table positional hierarchy in a call to `ibis.table`. I've updated the reprs for `UnboundTable` and `DatabaseTable` to show that hierarchy when it is specified. I've also swapped the attribute order for `ops.Namespace` as a convenience to allow unpacking the argnames in the correct hierarchical order.
gforsyth
force-pushed
the
unbound_namespace
branch
from
e89ced0 to
bcf332d
Compare
cpcloud
approved these changes
Mar 28, 2024
cpcloud
added
feature
Member
|
👌🏻 Nice UX improvement, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specifying 1 or 2 levels of table positional hierarchy in a
call to
ibis.table. I've updated the reprs forUnboundTableandDatabaseTableto show that hierarchy when it is specified.I've also swapped the attribute order for
ops.Namespaceas aconvenience to allow unpacking the argnames in the correct hierarchical
order.
Resolves #8253