feat(ddl): support create_schema and implement create_database as an abstract base class#6682
Merged
gforsyth merged 3 commits intoibis-project:masterfrom Aug 1, 2023
Merged
Conversation
cpcloud
added
feature
cpcloud
changed the title
create_schema and implement create_database as an abstract base class
cpcloud
force-pushed
the
database-ddl
branch
6 times, most recently
from
bf2e1de to
fe11004
Compare
gforsyth
reviewed
Jul 25, 2023
Member
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
implementation looks good and I'm all for making these consistent and available.
not sure what to do about force as a keyword argument.
cpcloud
force-pushed
the
database-ddl
branch
3 times, most recently
from
85abcf2 to
e822529
Compare
gforsyth
reviewed
Aug 1, 2023
Member
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Implementation looks good! I flagged a few docstring things that need fixing (I think).
I don't like force, but I think we can change that in a follow-up PR (and possibly following a deprecation cycle).
Co-authored-by: Gil Forsyth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for databases and schema creation and listing.
Closes #6331.