Skip to content

Commit 4556dad

Browse files
committed
chore(deps): bump DataFusion version from 51 to 53
DataFusion 52 introduced two behavior changes that require test updates: - DELETE DML is now implemented, so the insert-overwrite tests pass; drop the obsolete `notyet(["datafusion"], ... DELETE DML ...)` markers. - Volatile exprs are duplicated via projection pushdown into file scans, breaking impure-expression "lock-in", so mark the affected random/uuid impure tests `notyet`; see apache/datafusion#23220. Assisted-by: Claude Opus 4.8 <[email protected]>
1 parent 91f3a94 commit 4556dad

4 files changed

Lines changed: 21 additions & 18 deletions

File tree

‎ibis/backends/tests/test_client.py‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -578,9 +578,6 @@ def test_insert_no_overwrite_from_dataframe(
578578
raises=PsycoPg2InternalError,
579579
reason="truncate not supported upstream",
580580
)
581-
@pytest.mark.notyet(
582-
["datafusion"], raises=Exception, reason="DELETE DML not implemented upstream"
583-
)
584581
@pytest.mark.notyet(["druid"], raises=NotImplementedError)
585582
@pytest.mark.notyet(
586583
["athena"], raises=com.UnsupportedOperationError, reason="s3 location required"
@@ -628,9 +625,6 @@ def test_insert_no_overwrite_from_expr(
628625

629626

630627
@pytest.mark.notimpl(["polars"], reason="`insert` method not implemented")
631-
@pytest.mark.notyet(
632-
["datafusion"], raises=Exception, reason="DELETE DML not implemented upstream"
633-
)
634628
@pytest.mark.notyet(
635629
["risingwave"],
636630
raises=PsycoPg2InternalError,
@@ -658,9 +652,6 @@ def test_insert_overwrite_from_expr(
658652

659653

660654
@pytest.mark.notimpl(["polars"], reason="`insert` method not implemented")
661-
@pytest.mark.notyet(
662-
["datafusion"], raises=Exception, reason="DELETE DML not implemented upstream"
663-
)
664655
@pytest.mark.notyet(
665656
["risingwave"],
666657
raises=PsycoPg2InternalError,

‎ibis/backends/tests/test_impure.py‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,27 @@ def my_random(x: float) -> float: # noqa: ARG001
8585
return random.random() # noqa: S311
8686

8787

88+
# https://github.com/apache/datafusion/issues/23220
89+
datafusion_inlines_volatile = pytest.mark.notyet(
90+
["datafusion"],
91+
raises=AssertionError,
92+
reason="datafusion >= 52 duplicates volatile exprs via projection pushdown into the file scan",
93+
)
94+
8895
mark_impures = pytest.mark.parametrize(
8996
"impure",
9097
[
91-
pytest.param(lambda _: ibis.random(), marks=no_randoms, id="random"),
98+
pytest.param(
99+
lambda _: ibis.random(),
100+
marks=[*no_randoms, datafusion_inlines_volatile],
101+
id="random",
102+
),
92103
pytest.param(
93104
lambda _: ibis.uuid().cast(str).contains("a").ifelse(1, 0),
94105
marks=[
95106
*no_uuids,
96107
pytest.mark.notyet("impala", reason="instances are uncorrelated"),
108+
datafusion_inlines_volatile,
97109
],
98110
id="uuid",
99111
),

‎requirements-dev.txt‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎uv.lock‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)