Skip to content

GTFS spec updates#387

Merged
landonreed merged 18 commits intodevfrom
gtfs-spec-updates
Sep 2, 2021
Merged

GTFS spec updates#387
landonreed merged 18 commits intodevfrom
gtfs-spec-updates

Conversation

@br648
Copy link
Copy Markdown
Contributor

@br648 br648 commented Jun 4, 2021

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR seeks to integrate the latest GTFS spec updates made under the GTFS-lib PR (conveyal/gtfs-lib#312) in particular the two new table types: attributions and translations. This PR must not be merged until the depended GTFS-lib PR (conveyal/gtfs-lib#312) has been merged and a release created.

UpdateSQLFeedsMain args

"C:\projects\JetBrains\OTP\datatools-server\configurations\default\env.yml"
"C:\projects\JetBrains\OTP\datatools-server\configurations\default\server.yml"
"
ALTER TABLE #ns#.routes ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.stop_times ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.pattern_stops ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.stops ADD COLUMN IF NOT EXISTS platform_code SMALLINT, ADD COLUMN IF NOT EXISTS wheelchair_boarding SMALLINT;
ALTER TABLE #ns#.stops ALTER COLUMN wheelchair_boarding TYPE SMALLINT USING wheelchair_boarding::SMALLINT;
ALTER TABLE IF EXISTS #ns#.feed_info ADD COLUMN IF NOT EXISTS default_lang VARCHAR, ADD COLUMN IF NOT EXISTS feed_contact_email VARCHAR, ADD COLUMN IF NOT EXISTS feed_contact_url VARCHAR;
CREATE TABLE IF NOT EXISTS #ns#.translations (table_name VARCHAR, field_name VARCHAR, language VARCHAR, translation VARCHAR, record_id VARCHAR, record_sub_id VARCHAR, field_value VARCHAR);
CREATE TABLE IF NOT EXISTS #ns#.attributions (attribution_id VARCHAR, agency_id VARCHAR, route_id VARCHAR, trip_id VARCHAR, organization_name VARCHAR, is_producer SMALLINT, is_operator SMALLINT, is_authority SMALLINT, attribution_url VARCHAR, attribution_email VARCHAR, attribution_phone VARCHAR);
"
"snapshot_of IS NOT NULL"
"null"
"true"

@br648 br648 added the Awaiting GTFS-lib release Merge into dev once GTFS-lib has been released. label Jun 4, 2021
Copy link
Copy Markdown
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor formatting comments.

Copy link
Copy Markdown
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the failing tests. Perhaps it'd be good to develop a set of fake feeds with the minimum required data elements needed to simulate various merging possibilities.

@evansiroky evansiroky assigned br648 and unassigned evansiroky Jun 7, 2021
@br648 br648 requested a review from evansiroky June 11, 2021 15:01
@br648 br648 assigned evansiroky and unassigned br648 Jun 11, 2021
@evansiroky evansiroky removed their assignment Jun 17, 2021
Copy link
Copy Markdown
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New fields introduced (e.g. continuous_pickup) should be available when exporting a GTFS archive after setting values on these fields in the editor.

@br648 br648 removed their assignment Jul 23, 2021
@landonreed landonreed removed the Awaiting GTFS-lib release Merge into dev once GTFS-lib has been released. label Sep 2, 2021
BREAKING CHANGE: updated gtfs-lib dep requires schema change for postgres db using UpdateSQLFeedsMain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants