Merged
Conversation
…tables with related patch tests
added 2 commits
June 4, 2021 13:55
…ns to resolve referential integ
…transit package and all depende
binh-dam-ibigroup
approved these changes
Jun 7, 2021
Contributor
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
LGTM with minor formatting comments.
src/test/java/com/conveyal/datatools/editor/controllers/api/EditorControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/conveyal/datatools/editor/controllers/api/EditorControllerTest.java
Outdated
Show resolved
Hide resolved
evansiroky
reviewed
Jun 7, 2021
evansiroky
suggested changes
Jun 7, 2021
Contributor
evansiroky
left a comment
There was a problem hiding this comment.
Let's fix the failing tests. Perhaps it'd be good to develop a set of fake feeds with the minimum required data elements needed to simulate various merging possibilities.
…moved the serializer/deserializ
…ite GTFS datasets
Transit package removal
… references in SQL script. Plus
A build error (https://github.com/ibi-group/datatools-server/runs/2839437265#step:17:42) was encountered which appears to be related to optional chaining not being supported by 12.x.
evansiroky
approved these changes
Jun 17, 2021
binh-dam-ibigroup
requested changes
Jul 20, 2021
Contributor
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
New fields introduced (e.g. continuous_pickup) should be available when exporting a GTFS archive after setting values on these fields in the editor.
… and some of it's methods): A c
7 tasks
binh-dam-ibigroup
approved these changes
Sep 2, 2021
BREAKING CHANGE: updated gtfs-lib dep requires schema change for postgres db using UpdateSQLFeedsMain
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR seeks to integrate the latest GTFS spec updates made under the GTFS-lib PR (conveyal/gtfs-lib#312) in particular the two new table types: attributions and translations. This PR must not be merged until the depended GTFS-lib PR (conveyal/gtfs-lib#312) has been merged and a release created.
UpdateSQLFeedsMain args
"C:\projects\JetBrains\OTP\datatools-server\configurations\default\env.yml"
"C:\projects\JetBrains\OTP\datatools-server\configurations\default\server.yml"
"
ALTER TABLE #ns#.routes ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.stop_times ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.pattern_stops ADD COLUMN IF NOT EXISTS continuous_pickup SMALLINT, ADD COLUMN IF NOT EXISTS continuous_drop_off SMALLINT;
ALTER TABLE #ns#.stops ADD COLUMN IF NOT EXISTS platform_code SMALLINT, ADD COLUMN IF NOT EXISTS wheelchair_boarding SMALLINT;
ALTER TABLE #ns#.stops ALTER COLUMN wheelchair_boarding TYPE SMALLINT USING wheelchair_boarding::SMALLINT;
ALTER TABLE IF EXISTS #ns#.feed_info ADD COLUMN IF NOT EXISTS default_lang VARCHAR, ADD COLUMN IF NOT EXISTS feed_contact_email VARCHAR, ADD COLUMN IF NOT EXISTS feed_contact_url VARCHAR;
CREATE TABLE IF NOT EXISTS #ns#.translations (table_name VARCHAR, field_name VARCHAR, language VARCHAR, translation VARCHAR, record_id VARCHAR, record_sub_id VARCHAR, field_value VARCHAR);
CREATE TABLE IF NOT EXISTS #ns#.attributions (attribution_id VARCHAR, agency_id VARCHAR, route_id VARCHAR, trip_id VARCHAR, organization_name VARCHAR, is_producer SMALLINT, is_operator SMALLINT, is_authority SMALLINT, attribution_url VARCHAR, attribution_email VARCHAR, attribution_phone VARCHAR);
"
"snapshot_of IS NOT NULL"
"null"
"true"