Make sure to not modify the input options slice.#24
Closed
aalexand wants to merge 1 commit into
Closed
Conversation
In Go, appending to a slice can modify the original slice if there is enough backing space. In use cases like passing options slice to an API call this is unexpected since it's quite intuitive at the API surface to write a loop to demangle multiple names and reuse the same options slice between the calls. Forcing clients to copy or re-create the options in such pattern seems unnecessary.
aalexand
added a commit
to aalexand/pprof
that referenced
this pull request
Apr 17, 2025
This is a follow-up to google#924. In the comparison we should compare to the string with stripped underscore, otherwise the comparison will never be true and we strip the underscore in cases we shouldn't. See the added test case. Also, while we are here, add copying demangling options that we also missed. Hopefully we can get ianlancetaylor/demangle#24 in and this won't be needed.
Owner
|
Thanks. I fixed this in a different way and added a test. |
Contributor
Author
|
Thank you! TIL the neat way to address this. |
aalexand
added a commit
to google/pprof
that referenced
this pull request
Apr 17, 2025
This is a follow-up to #924. In the comparison we should compare to the string with stripped underscore, otherwise the comparison will never be true and we strip the underscore in cases we shouldn't. See the added test case. Also, while we are here, add copying demangling options that we also missed. Hopefully we can get ianlancetaylor/demangle#24 in and this won't be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Go, appending to a slice can modify the original slice if there is enough backing space. In use cases like passing options slice to an API call this is unexpected since it's quite intuitive at the API surface to write a loop to demangle multiple names and reuse the same options slice between the calls. Forcing clients to copy or re-create the options in such pattern seems unnecessary.