Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

bump version to 0.5.1 #330

Merged
merged 1 commit into from
May 30, 2023
Merged

bump version to 0.5.1 #330

merged 1 commit into from
May 30, 2023

Conversation

schmikei
Copy link
Contributor

Description

Trying to get a release out for @gabguy

@Yannig not sure if you want to take this but feel like we should release a patch version with the fix of #323

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Updated version in Makefile respecting semver v2

@Yannig
Copy link
Collaborator

Yannig commented May 30, 2023

Hi @schmikei

Thanks again for your time.

I was wondering if it could be a better solution to do a new release each time we merge on master.

Indeed currently, it is necessary to update the contents of the file Makefile with each release and the CI does not manage very well when the release already exists and that one merges new versions of lib for example.

A simpler solution might be to take a release number prefix and add today's date to it.

So the 0.5 version prefix would produce version 0.5.230530 for May 30, 2023 and version 0.5.230601 for June 1.

This way we will never have to worry about version but we will keep the current version schema.

What do you think about it ?

@schmikei
Copy link
Contributor Author

What do you think about it ?

Hmm I just think that kind of goes away from the versioning principles of Golang https://go.dev/doc/modules/version-numbers

I am in favor of maybe doing a docker push for every commit to main since we are just using GHCR to host the image and tag it with the GIT SHA on merges to main.

I think dedicated releases are a good thing to follow in open source and generally have milestones that may not warrant a full on release for a feature set. But that is where my head is at/my preference :) happy to hear what your preference would be!

@Yannig
Copy link
Collaborator

Yannig commented May 30, 2023

OK. Let's merge this for the moment.
I think it should be a good idea to use git sha to tag docker image but I don't have much time for the moment to change the Github action CI.

@Yannig Yannig merged commit 145b4ee into iamseth:master May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants