Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

try and fix non-initialized hashmap when using custom metrics #323

Merged
merged 1 commit into from
May 10, 2023

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented May 8, 2023

Description

This slipped through the cracks in my validation of the refactor. Would be good to have some test cases for any future refactors.

Fixes #321

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Updated version in Makefile respecting semver v2

@schmikei schmikei marked this pull request as ready for review May 8, 2023 14:12
@Yannig Yannig merged commit 99d5a44 into iamseth:master May 10, 2023
@Yannig
Copy link
Collaborator

Yannig commented May 10, 2023

Let's merge this for the moment.

@schmikei schmikei mentioned this pull request May 30, 2023
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"panic: assignment to entry in nil map" when using custom metrics as of 0.5.0
2 participants